[theme] Deprecate fade color utility in favor of alpha#22837
Merged
mnajdova merged 8 commits intomui:masterfrom Oct 7, 2020
Merged
[theme] Deprecate fade color utility in favor of alpha#22837mnajdova merged 8 commits intomui:masterfrom
fade color utility in favor of alpha#22837mnajdova merged 8 commits intomui:masterfrom
Conversation
Details of bundle changes.Comparing: cdbaeef...959c949 Details of page changes
|
mbrookes
previously requested changes
Oct 2, 2020
joshwooding
reviewed
Oct 2, 2020
Co-authored-by: Matt <github@nospam.33m.co>
Co-authored-by: Josh Wooding <12938082+joshwooding@users.noreply.github.com>
Co-authored-by: Matt <github@nospam.33m.co>
mnajdova
commented
Oct 5, 2020
oliviertassinari
approved these changes
Oct 7, 2020
joshwooding
approved these changes
Oct 7, 2020
42 tasks
oliviertassinari
pushed a commit
that referenced
this pull request
Nov 24, 2020
oliviertassinari
pushed a commit
that referenced
this pull request
Nov 24, 2020
oliviertassinari
pushed a commit
that referenced
this pull request
Jan 24, 2021
oliviertassinari
pushed a commit
that referenced
this pull request
Jan 25, 2021
|
When you revert a changeset, please explain in the comment why that change is being reverted. That would make it a lot easier to figure out what the intended end state is. |
Member
|
@ewanmellor What is your comment with reference to? |
The revert cset above (a194311) that reverts a87f8a2 on master without explanation. (Compounded by the four other csets that seem to be re-adding it on different branches.) |
Member
|
@ewanmellor This change will eventually land into a stable v4 release, we are batching depreciations under a pre-release. |
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR deprecates the
fadecolor utility in favor of the newalpha.Add deprecation for #22834