[docs] Fix @global being considered a class#22297
Merged
oliviertassinari merged 2 commits intomui:nextfrom Aug 21, 2020
Merged
Conversation
oliviertassinari
approved these changes
Aug 21, 2020
eps1lon
added a commit
to eps1lon/material-ui
that referenced
this pull request
Aug 22, 2020
42 tasks
1 task
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE
Remove deprecated
CssBaselineClassKeyTypeScript type. Using this class key always generated a runtime dev-only warning.Noticed that we wrongly generate a
@globalclass in the docs forInputBase. We already deprecated that class forCSSBaselineso we might as well fix the overall issue.The mention of default props in theme for CSSBaseline is not that useful since there's only
children. I still kept it for consistency. In the endwithStylescurrently does two things: default props override via theme and styling.