Closed
Conversation
Member
|
The warnings are gone be the circular progress doesn't behave correctly. Can you confirm? |
Contributor
Author
|
@oliviertassinari - it's behaving the same as material-ui.com - is that what you mean? |
Member
|
|
63b2cd7 to
5fb907d
Compare
Contributor
Author
|
had to remove the auto-prefixer stuff - think it is resetting the |
src/circular-progress.jsx
Outdated
Member
|
I can't merge this, it's no longer autoprefixed. Can't we do the same things as https://github.com/callemall/material-ui/pull/2007/files#diff-7b0d10ffdd18b87263fab49840fec31cR286? |
Contributor
Author
|
yes, although that is what was deleted.... |
5fb907d to
3f6d31a
Compare
Contributor
Author
|
@oliviertassinari think this one should be good to merge now |
Member
|
See #2047 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@oliviertassinari you can recreate on the docs page actually!
this fixes