[Breadcrumbs] Fix expand/collapsed Breadcrumbs via keyboard#19724
Merged
oliviertassinari merged 11 commits intomui:masterfrom Feb 20, 2020
Merged
[Breadcrumbs] Fix expand/collapsed Breadcrumbs via keyboard#19724oliviertassinari merged 11 commits intomui:masterfrom
oliviertassinari merged 11 commits intomui:masterfrom
Conversation
Details of bundle changes.Comparing: f2d74e9...dc883e6
|
eps1lon
reviewed
Feb 16, 2020
Member
eps1lon
left a comment
There was a problem hiding this comment.
Shouldn't we change the icon to implement the button role? I'm not sure about this implementation concerning a11y.
Contributor
Author
|
@oliviertassinari @eps1lon Could you please check a logic? If it is ok, I will change the tests. |
Member
oliviertassinari
left a comment
There was a problem hiding this comment.
We are getting closer. I still think that we need an aria label on the expand icon, otherwise, how can screenreaders know about it's impact?
packages/material-ui/src/Breadcrumbs/BreadcrumbCollapsed.test.js
Outdated
Show resolved
Hide resolved
| classes, | ||
| className, | ||
| component: Component = 'nav', | ||
| expandText = 'Show path', |
Member
There was a problem hiding this comment.
Taken from the aria-label Google Drive uses.
oliviertassinari
approved these changes
Feb 18, 2020
This was referenced Feb 19, 2020
dc883e6 to
c77ae7f
Compare
41f6352 to
42b97a6
Compare
Member
|
I have rebased on top of #19784 and improved the ripple + hover style. |
Member
|
@captain-yossarian Thank you for spending time on it! It's a really great improvement for accessibility :) |
This was referenced Mar 21, 2020
EsoterikStare
pushed a commit
to EsoterikStare/material-ui
that referenced
this pull request
Mar 30, 2020
This was referenced Apr 16, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #19708