Closed
Conversation
Member
|
@tyfoo Thanks for this PR. However, the issue you discribed is already fixed by #1922. |
Contributor
Author
|
@oliviertassinari thanks for the quick feedback. I am not sure #1922 solves this issue, as I believe the issue is cause by line 96 in clock.jsx: which it then passes to I believe that gets passed down as |
Contributor
|
@oliviertassinari I'm thinking if we can solve the problem at its root ( |
Contributor
|
See my last comment on #1674 guys |
Contributor
Author
|
@oliviertassinari @shaurya947 Thanks for the feedback. Should I close this PR? |
Member
|
@tyfoo Yes, I think that we can close this PR since the orignal issue is solved. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TimePicker dialog wont open when muiTheme is null/undefined. Steps to reproduce:
Source:
/src/time-picker/clock.jsxline 118<div style={this.prepareStyles(styles.root)}>, styles.root is{}.Fix: added a double check to
ensureDirectionto checkmuiThemeis notnullorundefinedbefore checking itsisRtlproperty.