[Input] Reset the line-height#10346
Merged
oliviertassinari merged 1 commit intomui:v1-betafrom Feb 19, 2018
Merged
Conversation
oliviertassinari
added a commit
to oliviertassinari/material-ui
that referenced
this pull request
Feb 19, 2018
It's no longer needed with mui#10346
Merged
oliviertassinari
added a commit
that referenced
this pull request
Feb 19, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
line-heightis inherited, it's easy to mess up the display of the input, e.g: https://codesandbox.io/s/2z5y03y81r.I believe it's safer to reset the property. It's also the approach used by Bootstrap and solves inconsistencies between the native/non-native select, input text/non-input-text.
Raised by @erikras