[code-infra] Rely on @mui/monorepo/.eslintrc#352
Conversation
3671c92 to
1dd89de
Compare
|
I don't think this is the best approach going forward. The Core repo should contain rules specific to it, not the shared code. The master eslint config (without project-specific overrides) should be moved to another repo and referenced from there. IMO we should treat @mui/material increasingly more as a Material UI project repository, not the home for all shared configs. |
@michaldudak I agree, when I look at https://github.com/mui/material-ui/blob/a90032f61a16117ceeda03ec943edd16f2b20dfb/.eslintrc.js#L416, it feels like having this outside of what Base UI imports is better. We should make it clear what's shared config (90% of the file) and Material UI specific (10% of the file). Now, I haven't seen a lot of cases where it's problematic. Usually when Material UI adds something, if it's specific to himself, it matches a path that MUI X doesn't have. Also having this would be great in Base UI: https://github.com/mui/mui-x/blob/4b07dfdbf67f5a6798ee71992656f40250124a50/.eslintrc.js#L162 |
|
I referenced the idea about splitting the ESLint config to mui/mui-public#213. |
Help remove duplication in the codebase.
Inspired me to try the same with the others: mui/mui-x#12864, mui/toolpad#3441.