Conversation
cfba06b to
868e1bd
Compare
bfbdd55 to
bc6a136
Compare
8b288b8 to
9e8baa3
Compare
|
I used |
I think this is a typo? Only applied when horizontal? I'm still seeing a missing symbol |
Yup, just corrected it.
OK then, I'll play it safe 
|
| const [, forceUpdate] = React.useState({}); | ||
|
|
There was a problem hiding this comment.
There's an existing useForceRender util
| const prehydrationScript = ` | ||
| (function() { | ||
| let indicator = document.currentScript.previousElementSibling; | ||
| if (!indicator) { |
There was a problem hiding this comment.
I think it may be better to store the source of this in its own file (unused) and use a minified version here?
There was a problem hiding this comment.
I created a utility to minify and inline scripts in 30412c2
| ...other | ||
| } = props; | ||
| const render = renderProp ?? defaultRenderFunctions.span; | ||
| const [instanceId] = React.useState(() => Math.random().toString(36).slice(2)); |
There was a problem hiding this comment.
Doesn't work during SSR in React 17 :(
| * Callback invoked when new value is being set. | ||
| */ | ||
| onChange?: (event: React.SyntheticEvent, value: any) => void; |
There was a problem hiding this comment.
As discussed, it should be better to prefer different prop names like onValueChange that passes in the value first.
|
Ready to 🚀 on my side |
44562c3 to
b73f72f
Compare
1f9fc7e to
e902605
Compare
selectionFollowsFocusprop toactivateOnFocusand moved it to TabsList.loopprop to the Tabs.keepMountedprop to the TabPanelTo do:
valuenordefaultValueis setkeepMountedprop on TabPanelsSliding tab panels-> in a separate PRScrollable tab list-> in a separate PRPreview:
Closes #212
Closes #81