Merged
Conversation
✅ Deploy Preview for base-ui ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
mj12albert
commented
Feb 10, 2025
docs/src/app/(public)/(content)/react/components/meter/demos/hero/css-modules/index.module.css
Outdated
Show resolved
Hide resolved
5f3f9a4 to
91c0d7c
Compare
This comment was marked as outdated.
This comment was marked as outdated.
michaldudak
reviewed
Mar 7, 2025
michaldudak
reviewed
Mar 18, 2025
| }); | ||
|
|
||
| namespace MeterRoot { | ||
| export type State = { |
Member
There was a problem hiding this comment.
I'm wondering if it's necessary to have these in state. They come directly from props.
Member
Author
There was a problem hiding this comment.
Good point, it's really just for consistency but they don't generate a data attr, other components probably don't need this in the state either
Comment on lines
+59
to
+61
| 'aria-valuenow': percentageValue / 100, | ||
| 'aria-valuetext': getAriaValueText | ||
| ? getAriaValueText(value) |
Member
There was a problem hiding this comment.
These could be rounded so they don't include too many decimals (or even any at all).
Member
Author
There was a problem hiding this comment.
Fixed ~ it should actually be getAriaValueText(formattedValue, value) here to match the Value's children function
Contributor
|
colmtuite
approved these changes
Apr 7, 2025
Member
Author
Updated and added the tailwind version:
|
michaldudak
pushed a commit
to michaldudak/base-ui
that referenced
this pull request
Apr 8, 2025
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Docs: https://deploy-preview-1435--base-ui.netlify.app/react/components/meter
Demo: https://deploy-preview-1435--base-ui.netlify.app/experiments/meter
Summary
meterelement due to numerous cross-browser inconsistencies 12Progresssince they are closely related, e.g.Valuesubcomponent,formatproplocaleprop to match [number field] Addlocaleprop #1488Closes #662
Footnotes
https://www.htmhell.dev/adventcalendar/2022/5/ ↩
https://scottaohara.github.io/a11y_styled_form_controls/src/meter/ ↩