fix: correctly propagate error during model load #7610
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for localai ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Signed-off-by: Ettore Di Giacinto <mudler@localai.io>
6a6347f to
c8a0cea
Compare
sredman
pushed a commit
to sredman/LocalAI
that referenced
this pull request
Dec 20, 2025
Signed-off-by: Ettore Di Giacinto <mudler@localai.io> Signed-off-by: Simon Redman <simon@ergotech.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes a shadowing bug when loading model fails and we don't correctly propagate errors to the caller. This causes a nil pointer dereference long the line because if the error is nil it is implied that a client is returned in many other code pieces.
Notes for Reviewers
Signed commits