Skip to content

FF ON to consume Vehicle Location providers from main app#103

Merged
mmathieum merged 4 commits into
masterfrom
mm/vehicle_app_ff_on
Feb 17, 2026
Merged

FF ON to consume Vehicle Location providers from main app#103
mmathieum merged 4 commits into
masterfrom
mm/vehicle_app_ff_on

Conversation

@mmathieum

@mmathieum mmathieum commented Feb 9, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

@mmathieum mmathieum self-assigned this Feb 9, 2026
@gemini-code-assist

gemini-code-assist Bot commented Feb 9, 2026

Copy link
Copy Markdown
Contributor

Summary of Changes

Hello @mmathieum, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on activating a specific feature flag, F_CONSUME_VEHICLE_LOCATION, which is crucial for integrating vehicle location provider consumption into the main application. This change is a foundational step towards leveraging real-time vehicle data, with its functionality tied to another existing feature flag.

Highlights

  • Feature Flag Activation: The F_CONSUME_VEHICLE_LOCATION feature flag has been enabled within UIFeatureFlags.kt. This change allows the main application to consume vehicle location providers, contingent on the FeatureFlags.F_EXPORT_TRIP_ID flag also being active.
Changelog
  • app-android/src/main/java/org/mtransit/android/util/UIFeatureFlags.kt
    • Enabled the F_CONSUME_VEHICLE_LOCATION constant by changing its value from false to true, allowing the application to consume vehicle location providers.
Activity
  • No specific activity (comments, reviews, or progress updates) has been provided in the context for this pull request.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist[bot]
gemini-code-assist Bot reviewed Feb 9, 2026
View reviewed changes

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request enables the F_CONSUME_VEHICLE_LOCATION feature flag. The change is straightforward, and I've kept the suggestion to improve code clarity by removing a redundant boolean operation.

Comment thread app-android/src/main/java/org/mtransit/android/util/UIFeatureFlags.kt Outdated
mmathieum added a commit to mtransitapps/commons that referenced this pull request Feb 9, 2026
@mmathieum
FF ON to export Vehicle Location providers in module apps
1bd47a1 
- mtransitapps/mtransit-for-android#103
@mmathieum mmathieum mentioned this pull request Feb 9, 2026
Merged
@mmathieum mmathieum marked this pull request as ready for review February 16, 2026 13:47
mmathieum added a commit to mtransitapps/commons that referenced this pull request Feb 17, 2026
@mmathieum
FF ON to export Vehicle Location providers in module apps (#556)
7f24dc5 
- mtransitapps/mtransit-for-android#103
@mmathieum mmathieum merged commit 93a074f into master Feb 17, 2026
6 checks passed
@mmathieum mmathieum deleted the mm/vehicle_app_ff_on branch February 17, 2026 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@mmathieum mmathieum

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@mmathieum