Skip to content

Strings cleaner > fix Line replacement & always "@"#29

Merged
mmathieum merged 3 commits into
masterfrom
mm/wip
Mar 26, 2026
Merged

Strings cleaner > fix Line replacement & always "@"#29
mmathieum merged 3 commits into
masterfrom
mm/wip

Conversation

@mmathieum

Copy link
Copy Markdown
Member

No description provided.

@mmathieum mmathieum self-assigned this Mar 26, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the 'LINE' regex pattern in CleanUtils to use manual compilation with case-insensitivity and introduces a specific replacement string to preserve surrounding whitespace. Additionally, in StringsCleaner, the 'CLEAN_AT' replacement is moved to execute regardless of the 'short' parameter. A review comment suggests simplifying the 'LINE' regex by removing a redundant capturing group and updating the replacement indices for better efficiency.

Comment thread src/main/java/org/mtransit/commons/CleanUtils.java Outdated
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
@mmathieum mmathieum marked this pull request as ready for review March 26, 2026 19:13
@mmathieum mmathieum merged commit bb4ff33 into master Mar 26, 2026
4 checks passed
@mmathieum mmathieum deleted the mm/wip branch March 26, 2026 19:26
montransit added a commit to mtransitapps/mtransit-for-android that referenced this pull request Mar 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant