Skip to content
This repository was archived by the owner on Nov 9, 2017. It is now read-only.

Conversation

@ctrueden
Copy link
Contributor

Since vi(m) is Git's default editor, and vi(m) has a steep learning curve, shipping the vimtutor will help mitigate some of that difficulty for new users.

Addresses issue #217.

ctrueden added 2 commits June 19, 2014 15:59
This is the exact same vimtutor from the vim source repository:

  https://vim.googlecode.com/hg/src/vimtutor

It works as is in MSYS, although there are a couple of warnings:

  /bin/vimtutor: line 28: mktemp: command not found
  /bin/vimtutor: line 28: tempfile: command not found

Since these utilities are not present.

However, the script has a contingency for that scenario, and manages to
create a temporary copy of the tutor file anyway, so all is well.

Signed-off-by: Curtis Rueden <ctrueden@wisc.edu>
This copies the vimtutor shell script, along with all the vim tutor
files themselves in various languages, into the Git for Windows
distribution.

Since vi(m) is Git's default editor, and vi(m) has a steep learning
curve, shipping the vimtutor will help mitigate some of that difficulty
for new users. After all, they have enough on their plates learning Git,
without being stuck in an editor they do not know how to control, too!

Fixes issue #217.

Signed-off-by: Curtis Rueden <ctrueden@wisc.edu>
@ctrueden
Copy link
Contributor Author

I am sorry to say that I did not test that the new copy-files.sh works, because being a n00b to msysgit development, I did not know how. I am similarly uncertain whether the change above specifies the entire tutor directory correctly. I did at least verify that vimtutor launches the tutor as expected in a developer installation.

I am happy to test if you wouldn't mind giving me a quick pointer regarding how to do so.

@dscho
Copy link
Member

dscho commented Jun 19, 2014

@ctrueden no problem. You usually build an installer using /share/WinGit/release.sh <version> (or a portable release with /share/WinGit/portable-release.sh <version> and test that. I'm on it.

dscho added a commit that referenced this pull request Jun 20, 2014
This adds the vimtutor script to help new users with vi, since it
is still our default editor.

Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
@dscho
Copy link
Member

dscho commented Jun 20, 2014

Thank you! I merged a slightly modified version (editing the line causing the warning, as you had suggested).

@dscho dscho closed this Jun 20, 2014
@dscho
Copy link
Member

dscho commented Jun 20, 2014

To make it easier what I merged, here a link: 903b82e^...903b82e^2

@ctrueden ctrueden deleted the vimtutor branch June 20, 2014 15:32
@ctrueden
Copy link
Contributor Author

Thank you @dscho!

@dscho dscho mentioned this pull request Jun 20, 2014
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants