toolchain: replace x86_64-pc-msys with x86_64-pc-cygwin#5448
Merged
Conversation
4 tasks
Member
Author
|
@dscho do you have any concerns, or preferences when I should land this? |
Contributor
|
@lazka I do not have any good intuition about the fallout from this, so I'd say: go ahead at your preferred pace. I'll try to deal with the consequences on Git for Windows' and msys2-runtime's side as best as I can. |
dscho
reviewed
Jun 16, 2025
* build with cygwin triplet, switch uname to cygwin * 0100-binutils-2.37-msys2.patch: * remove all changes that are no longer needed with a cygwin host * move all msys specific changes into the cygwin conditions
0950-11.2.0-configure-msys2.patch: drop everything and patch the cygwin paths instead. One hunk re SUPPORTS_WEAK is dropped since I don't think that does anything for cygwin. 0951-11.2.0-msys2-spec.patch: compare everything and patch the cygwin files instead. I'm not sure if the multilib change does anything, but keeping it anyway. 0953-11.2.0-testsuite-msys2.patch: no longer needed, all conditions are true with the cygwin triplet.
In theory this means the "0001-Add-MSYS2-triplet.patch" patch can be dropped.
Member
Author
|
Here is he accompanying news entry: https://github.com/msys2/msys2.github.io/pull/387/files |
lazka
added a commit
to lazka/msys2.github.io
that referenced
this pull request
Jun 20, 2025
lazka
added a commit
to msys2/msys2.github.io
that referenced
this pull request
Jun 20, 2025
Member
Author
|
This change is now in the repo. |
Contributor
|
scary |
lazka
added a commit
that referenced
this pull request
Jun 27, 2025
Since #5448 CHOST defaults to cygwin now, so this is no longer needed.
Spasi
added a commit
to Spasi/jdk
that referenced
this pull request
Jun 12, 2026
Spasi
added a commit
to Spasi/jdk
that referenced
this pull request
Jun 12, 2026
Spasi
added a commit
to Spasi/jdk
that referenced
this pull request
Jun 12, 2026
Spasi
added a commit
to Spasi/jdk
that referenced
this pull request
Jun 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #3012