Small fixes around coercions and rec info#7
Merged
mshinwell merged 3 commits intomshinwell:flambda2-types-rec-modulesfrom Oct 20, 2021
Merged
Conversation
`Rec_info_expr` was failing to report free names in the given mode; `Type_grammar` was failing to give `Rec_info_expr` the correct mode; and coercion applications should just throw fatal errors rather than returning bottom.
mshinwell
pushed a commit
that referenced
this pull request
Mar 9, 2022
da6ff04 Accept [@ocaml.local] without -extension, and move autogenerated attrs to [@extension.local] (#9) 30ce67d Improve inclusion error messages for [@local_opt] (#10) f925a62 Remove some uneeded mode variables (#8) dec721c Local solver speedups (#7) e9afc49 Fix check_all_arches build 0b9b32a Fix i386 build a515093 Merge flambda-backend changes git-subtree-dir: ocaml git-subtree-split: da6ff04
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rec_info_exprwas failing to report free names in the given mode;Type_grammarwas failing to giveRec_info_exprthe correct mode;and coercion applications should just throw fatal errors rather than
returning bottom.