Don't apply coercions deeply (except for closures)#6
Merged
mshinwell merged 1 commit intomshinwell:flambda2-types-rec-modulesfrom Oct 20, 2021
Merged
Conversation
Coercions only apply to their own domains - that is, a coercion on closures doesn't apply to pairs (which might contain, say, a closure and an int). So we don't want to recurse into types in general when applying coercions. Unfortunately, the situation with closures is ... complicated, as explained in comments.
mshinwell
pushed a commit
that referenced
this pull request
Oct 20, 2021
Coercions only apply to their own domains - that is, a coercion on closures doesn't apply to pairs (which might contain, say, a closure and an int). So we don't want to recurse into types in general when applying coercions. Unfortunately, the situation with closures is ... complicated, as explained in comments.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Coercions only apply to their own domains - that is, a coercion on
closures doesn't apply to pairs (which might contain, say, a closure
and an int). So we don't want to recurse into types in general when
applying coercions. Unfortunately, the situation with closures is
... complicated, as explained in comments.