Support with syntax#41
Merged
mshinwell merged 13 commits intomshinwell:5.2.0-parallelfrom Sep 9, 2024
Merged
Conversation
…des` (oxcaml#2925) * Subsume transl_modalities into Typemode * Modify error message for unrecognized modifier and add jkind tests * Fix formatting * Add jkind_axis and refactor typemodifier into typemode * Reformat * some edits --------- Co-authored-by: Zesen Qian <github@riaqn.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also contains changes from oxcaml#2925
Issues remaining to resolve:
Check that all ~type_equal is passed correctly. Set it to assert false if possible for sanity.
(Fixed) Currently printing of recursive types will hang:
type r = R of r list [@@unboxed]
let rec a = R [a];;
[%%expect{|
type r = R of r list [@@unboxed]
val a : r = R []
|}];;
Probably related code: search in genprintval.ml, or reduce_bound in jkind.ml
Currently we are printing value mod (ty) instead of value mod 'a. Yeah that's a string literal (ty). This is to help debug the previous point. UPDATE: I can't just use
Printtyp.tree_of_typexpfor that - I need to do things similar totree_of_type_decl. Too much work so I gave up.Currently only option and list in predef.ml support this. We should support user syntax as well. The parsing and everything is already done, the blocking bit is about duplicated call in typedecl.ml.
If possible, also do some clean-up of the code.