Register address so that DefaultFactory doesn't get GC'd#134
Closed
tenderlove wants to merge 1 commit intomsgpack:masterfrom
Closed
Register address so that DefaultFactory doesn't get GC'd#134tenderlove wants to merge 1 commit intomsgpack:masterfrom
tenderlove wants to merge 1 commit intomsgpack:masterfrom
Conversation
This program will SEGV without registering the global: ``` $ ruby -Ilib -rmsgpack -e'MessagePack::DefaultFactory = nil; GC.start; "".to_msgpack' ```
This was referenced Mar 10, 2017
tenderlove
added a commit
to github/ruby
that referenced
this pull request
Mar 10, 2017
This is a work around for a bug in msgpack. It should be fixed by: * msgpack/msgpack-ruby#134 * msgpack/msgpack-ruby#135
Member
|
I've merged #135 instead of this change. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This program will SEGV without registering the global:
This fixes #133 by registering the address so that the object does not get GC'd