Skip to content

[Sync] Update project files from source repository (425438b)#104

Merged
mrz1836 merged 1 commit intomasterfrom
chore/sync-files-mrz-tools-20260130-123257-425438b
Jan 30, 2026
Merged

[Sync] Update project files from source repository (425438b)#104
mrz1836 merged 1 commit intomasterfrom
chore/sync-files-mrz-tools-20260130-123257-425438b

Conversation

@mrz1836
Copy link
Owner

@mrz1836 mrz1836 commented Jan 30, 2026

What Changed

  • Updated error message in fortress-benchmarks.yml to include a title attribute and more detailed failure information indicating panic, fatal, or timeout scenarios with reference to job summary
  • Modified input and timing data parsing in fortress-completion-finalize.yml to use base64 encoding/decoding and heredoc syntax for safely handling multiline values
  • Normalized environment variable keys by replacing hyphens with underscores (e.g., env-json becomes env_json) for GitHub Actions expression compatibility
  • Changed from simple key=value parsing to a multi-line heredoc approach with EOF delimiters (EOF_INPUT_<key> and EOF_TIMING_<key>) for both input and timing data
  • Added continue-on-error configuration to artifact download step in the completion finalize workflow

Why It Was Necessary

  • The enhanced error message provides clearer diagnostics when benchmarks fail, making it easier to identify the failure type and locate details in the job summary
  • Base64 encoding and heredoc syntax prevent parsing failures when environment variable values contain newlines or special characters (particularly important for complex JSON data like env-json)
  • Normalizing hyphens to underscores in variable names ensures compatibility with GitHub Actions expression syntax, which doesn't support hyphens in variable references

Testing Performed

  • Verify that benchmark failures now display the enhanced error message with title and detailed context
  • Test parsing of multiline input values (especially JSON data) to ensure they are correctly stored in environment variables
  • Confirm that normalized variable names (with underscores) are accessible in subsequent workflow steps using GitHub Actions expressions
  • Validate that artifact download continues appropriately based on the continue-on-error configuration

Impact / Risk

  • Low risk - Changes primarily improve error reporting and fix data parsing edge cases without altering core workflow logic
  • No breaking changes - The variable normalization is internal to the workflow and maintains backward compatibility
  • Improved reliability - Better handling of multiline values reduces potential parsing failures in complex workflow scenarios

@mrz1836 mrz1836 self-assigned this Jan 30, 2026
@mrz1836 mrz1836 added automated-sync Automated sync PR, e.g. from a fork or external repo automerge Label to automatically merge pull requests that meet all required conditions chore Simple dependency updates or version bumps labels Jan 30, 2026
@github-actions github-actions bot added update General updates size/XL Very large change (>500 lines) labels Jan 30, 2026
@github-actions
Copy link
Contributor

Code Coverage Analysis

🟡 Overall Coverage: 85.2%
No Go files modified in this PR

Project coverage remains at 85.2% (3.1K/3.7K statements)

Changes: 10 config files

Coverage Metrics

Metric Value Grade Trend
Percentage 85.2% ⭐ B+ 📊
Statements 3.1K/3.7K ⭐ B+ No change
Quality Score 85.2/100 ⭐ B+ 📈

Coverage Breakdown

████████████░░░ 85.2%

Resources


Generated via go-coverage2026-01-30 17:38:16 UTC

github-actions bot added a commit that referenced this pull request Jan 30, 2026
🏷️ Generated with GoFortress
@mrz1836
Copy link
Owner Author

mrz1836 commented Jan 30, 2026

LGTM!

@mrz1836 mrz1836 merged commit 8bc570a into master Jan 30, 2026
44 checks passed
@github-actions github-actions bot deleted the chore/sync-files-mrz-tools-20260130-123257-425438b branch January 30, 2026 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

automated-sync Automated sync PR, e.g. from a fork or external repo automerge Label to automatically merge pull requests that meet all required conditions chore Simple dependency updates or version bumps size/XL Very large change (>500 lines) update General updates

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant