Change alias 'three-nodes' → 'three/nodes'#24413
Merged
mrdoob merged 4 commits intomrdoob:devfrom Aug 25, 2022
Merged
Conversation
sunag
approved these changes
Aug 1, 2022
Collaborator
sunag
left a comment
There was a problem hiding this comment.
I think it's a positive change due to the many reports of issues.
LeviPesin
reviewed
Aug 1, 2022
LeviPesin
reviewed
Aug 1, 2022
Contributor
|
Also related: #23406 |
Contributor
|
Makes sense, thanks for the PR! 👍 |
Contributor
|
@donmccurdy could you solve the conflicts on this PR? Also I think this PR should be merged soon to avoid any more confusion for the users. |
Collaborator
|
Updated! |
Owner
|
Thanks! |
abernier
pushed a commit
to abernier/three.js
that referenced
this pull request
Sep 16, 2022
* Change alias 'three-nodes' → 'three/nodes' * Clean up * update new examples Co-authored-by: sunag <jcdeconto@igalia.com>
snagy
pushed a commit
to snagy/three.js-1
that referenced
this pull request
Sep 21, 2022
* Change alias 'three-nodes' → 'three/nodes' * Clean up * update new examples Co-authored-by: sunag <jcdeconto@igalia.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related:
In my opinion, any aliases in exported modules should be under the
three/*namespace. Otherwise, it looks like an import from an unknown NPM module to tooling. If we'd like to do so, we could add thethree/nodesentry inpackage.json#exports, allowing bundlers and some CDNs to resolve this import automatically, but I haven't taken that extra step here./cc @sunag @marcofugaro @robertlong