Merged
Conversation
20 tasks
283bea3 to
3af2981
Compare
Repository owner
deleted a comment from
nyan-left
Mar 11, 2022
Collaborator
|
oops. reconstructing the essence of a side discussion between @nyan-left and @WestLangley... @WestLangley said:
|
donmccurdy
commented
Mar 11, 2022
Collaborator
Author
|
This PR is ready for review — given the changes coming in #23392, publishing the these docs with r139 might be ideal. @WestLangley — no pressure, but I'm happy to make any changes you'd recommend here! |
Owner
|
Thanks! |
Collaborator
|
@donmccurdy Better late than never... I just want to say thank you for all your work on this. :-) |
abernier
pushed a commit
to abernier/three.js
that referenced
this pull request
Sep 16, 2022
* Color Management: Documentation * Color Management: Clean up documentation * Documentation: Add color space constants. * Color management: Documentation revisions. * Color Management: Remove unused illustration. * Color Management: Revisions to documentation. * Color Management: Documentation should use title case.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Documentation accompanying #23392. Explains concepts required for three.js users to understand color management, including:
Live Preview: three.js / docs / getting started / color management
/cc @gkjohnson @WestLangley @Mugen87
Aside: I'm very grateful to @WestLangley for explaining foundational color science concepts to me, and to @sobotka for correcting my (many) misconceptions in this process. Any mistakes in this PR are of course mine, and I hope the new documentation can pay their help forward to the three.js community somewhat.☺️