Skip to content

console.lua: exit when left clicking outside of selectable items#15145

Merged
kasper93 merged 1 commit intompv-player:masterfrom
guidocella:console-esc
Oct 21, 2024
Merged

console.lua: exit when left clicking outside of selectable items#15145
kasper93 merged 1 commit intompv-player:masterfrom
guidocella:console-esc

Conversation

@guidocella
Copy link
Copy Markdown
Contributor

No description provided.

@github-actions
Copy link
Copy Markdown

Download the artifacts for this pull request:

Windows
macOS

@kasper93
Copy link
Copy Markdown
Member

Don't see why not. Thanks.

@kasper93 kasper93 merged commit 0dc2e85 into mpv-player:master Oct 21, 2024
@guidocella guidocella deleted the console-esc branch October 21, 2024 20:27
@verygoodlee
Copy link
Copy Markdown
Contributor

right-click exit introduced in #15036 may need to revert, we don't need 2 mouse keys to exit.

right-click is used to pause by default, or used to open context-menu in some third-party osc script,
we should try not to change their behavior as much as possible.

@guidocella
Copy link
Copy Markdown
Contributor Author

Right click is still needed to close the console while the cursor is on most of the screen. No default behavior is changed because these bindings are only active while the console is open.

@verygoodlee
Copy link
Copy Markdown
Contributor

input area at the bottom is outside of selectable items, can always left-click it to exit,
the only problem is that the default font size is too small, making the height of the input area too low,
this will no longer be a problem if #15044 is solved.

these bindings are only active while the console is open.

I know this but I cannot use the right-click to open context-menu while the console is open, which is quite annoying.

@guidocella
Copy link
Copy Markdown
Contributor Author

Yes the default font size is terrible, but there's nothing I can do about it unless more people vote to increase it.

GUI applications also close open menus if you try to open the context menu so I don't understand how this is a problem only for console.

guidocella added a commit to guidocella/mpv that referenced this pull request Oct 27, 2024
Make the console easier to read because the current default is too
small. See for example
mpv-player#14903 (reply in thread)
or mpv-player#15036 (comment)
or mpv-player#15145 (comment)
or mpv-player#15031 (comment).

This also prevents libass from decreasing performance by printing many
lines.
kasper93 pushed a commit that referenced this pull request Oct 27, 2024
Make the console easier to read because the current default is too
small. See for example
#14903 (reply in thread)
or #15036 (comment)
or #15145 (comment)
or #15031 (comment).

This also prevents libass from decreasing performance by printing many
lines.
verygoodlee added a commit to verygoodlee/mpv that referenced this pull request Feb 7, 2025
This is an improvement on mpv-player#15145 .
If the cursor is automatically hidden, users may not know whether
they are clicking on the inside or outside of selectable items, 
the result after clicking is unclear to them.
guidocella added a commit to guidocella/mpv that referenced this pull request Feb 8, 2025
This reverts commit ad0c29e.

This should be unnecessary now that the menu has a visible horizontal
and vertical hitbox, and was not discoverable anyway. Right click can be
useful even while the console is open to pause or open a context menu.
Requested in
mpv-player#15145 (comment).
guidocella added a commit to guidocella/mpv that referenced this pull request Feb 8, 2025
This reverts commit ad0c29e.

This should be unnecessary now that the menu has a visible horizontal
and vertical hitbox, and was not discoverable anyway. Right click can be
useful even while the console is open to pause or open a context menu.
Requested in
mpv-player#15145 (comment).
guidocella added a commit to guidocella/mpv that referenced this pull request Feb 8, 2025
This reverts commit ad0c29e.

This should be unnecessary now that the menu has a visible horizontal
and vertical hitbox, and was not discoverable anyway. Right click can be
useful even while the console is open to pause or open a context menu.
Requested in
mpv-player#15145 (comment).
guidocella added a commit to guidocella/mpv that referenced this pull request Feb 8, 2025
This reverts commit ad0c29e.

This should be unnecessary now that the menu has a visible horizontal
and vertical hitbox, and was not discoverable anyway. Right click can be
useful even while the console is open to pause or open a context menu.
Requested in
mpv-player#15145 (comment).
guidocella added a commit to guidocella/mpv that referenced this pull request Feb 8, 2025
This reverts commit ad0c29e.

This should be unnecessary now that the menu has a visible horizontal
and vertical hitbox, and was not discoverable anyway. Right click can be
useful even while the console is open to pause or open a context menu.
Requested in
mpv-player#15145 (comment).
guidocella added a commit to guidocella/mpv that referenced this pull request Feb 9, 2025
This reverts commit ad0c29e.

This should be unnecessary now that the menu has a visible horizontal
and vertical hitbox, and was not discoverable anyway. Right click can be
useful even while the console is open to pause or open a context menu.
Requested in
mpv-player#15145 (comment).
guidocella added a commit to guidocella/mpv that referenced this pull request Feb 9, 2025
This reverts commit ad0c29e.

This should be unnecessary now that the menu has a visible horizontal
and vertical hitbox, and was not discoverable anyway. Right click can be
useful even while the console is open to pause or open a context menu.
Requested in
mpv-player#15145 (comment).
kasper93 pushed a commit to kasper93/mpv that referenced this pull request Feb 9, 2025
This reverts commit ad0c29e.

This should be unnecessary now that the menu has a visible horizontal
and vertical hitbox, and was not discoverable anyway. Right click can be
useful even while the console is open to pause or open a context menu.
Requested in
mpv-player#15145 (comment).
guidocella added a commit to guidocella/mpv that referenced this pull request Feb 12, 2025
This reverts commit ad0c29e.

This should be unnecessary now that the menu has a visible horizontal
and vertical hitbox, and was not discoverable anyway. Right click can be
useful even while the console is open to pause or open a context menu.
Requested in
mpv-player#15145 (comment).
guidocella added a commit to guidocella/mpv that referenced this pull request Feb 17, 2025
This reverts commit ad0c29e.

This should be unnecessary now that the menu has a visible horizontal
and vertical hitbox, and was not discoverable anyway. Right click can be
useful even while the console is open to pause or open a context menu.
Requested in
mpv-player#15145 (comment).
github-merge-queue bot pushed a commit that referenced this pull request Feb 17, 2025
This reverts commit ad0c29e.

This should be unnecessary now that the menu has a visible horizontal
and vertical hitbox, and was not discoverable anyway. Right click can be
useful even while the console is open to pause or open a context menu.
Requested in
#15145 (comment).
verygoodlee added a commit to verygoodlee/mpv that referenced this pull request Feb 18, 2025
This is an improvement on mpv-player#15145 .
If the cursor is automatically hidden, users may not know whether
they are clicking on the inside or outside of selectable items,
the result after clicking is unclear to them.
verygoodlee added a commit to verygoodlee/mpv that referenced this pull request Mar 14, 2025
This is an improvement on mpv-player#15145 .
If the cursor is automatically hidden, users may not know whether
they are clicking on the inside or outside of selectable items,
the result after clicking is unclear to them.
Dudemanguy pushed a commit that referenced this pull request Mar 14, 2025
This is an improvement on #15145 .
If the cursor is automatically hidden, users may not know whether
they are clicking on the inside or outside of selectable items,
the result after clicking is unclear to them.
HopperLogger pushed a commit to HopperLogger/mpv-frame-interpolator that referenced this pull request Mar 26, 2025
This reverts commit ad0c29e.

This should be unnecessary now that the menu has a visible horizontal
and vertical hitbox, and was not discoverable anyway. Right click can be
useful even while the console is open to pause or open a context menu.
Requested in
mpv-player#15145 (comment).
HopperLogger pushed a commit to HopperLogger/mpv-frame-interpolator that referenced this pull request Mar 26, 2025
This is an improvement on mpv-player#15145 .
If the cursor is automatically hidden, users may not know whether
they are clicking on the inside or outside of selectable items,
the result after clicking is unclear to them.
trim21 pushed a commit to trim21/mpv that referenced this pull request Dec 25, 2025
This reverts commit ad0c29e.

This should be unnecessary now that the menu has a visible horizontal
and vertical hitbox, and was not discoverable anyway. Right click can be
useful even while the console is open to pause or open a context menu.
Requested in
mpv-player#15145 (comment).
trim21 pushed a commit to trim21/mpv that referenced this pull request Dec 25, 2025
This is an improvement on mpv-player#15145 .
If the cursor is automatically hidden, users may not know whether
they are clicking on the inside or outside of selectable items,
the result after clicking is unclear to them.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants