Change bernoulli(1) and bernfrac(1) to +½#639
Change bernoulli(1) and bernfrac(1) to +½#639Parcly-Taxel wants to merge 10 commits intompmath:masterfrom
bernoulli(1) and bernfrac(1) to +½#639Conversation
This commit is part of the project at sympy/sympy#23926 and also fixes mpmath#604
skirpichev
left a comment
There was a problem hiding this comment.
I also would prefer a better commit message (describe reasons to change, etc).
By accepting this patch, we will be in sync with the SymPy. But most of mathematical software still uses the current mpmath's convention (e.g. Mathematica's BernoulliB or scipy.special.bernoulli). @fredrik-johansson, what do you think?
bernoulli(1) and bernfrac(1) to +½
There was a problem hiding this comment.
Ok, this seems to be correct. Of course, docstrings could be better, and there are still many unrelated changes.
Lets wait for Fredrik's opinion: if this does make sense at all (I'm +0).
UPD: https://groups.google.com/g/sage-devel/c/G4sbKoibXK4/m/LmO04RclCAAJ
skirpichev
left a comment
There was a problem hiding this comment.
After reading flintlib/flint#1179 and sage discussion, I think we should be more conservative.
Lets follow to the Fredrik's suggestion and introduce a keyword (plus?) for related functions (bernoulli and bernfrac). The default value should correspond to the current convention.
Please adapt code and docstrings.
|
I fixed merge conflicts, yet I'm closing this stale pr. Feel free to reopen it if you wish, but please adapt first code as it was suggested above (in short: control new behaviour with an option). |
This commit is part of the project at sympy/sympy#23926 Co-authored-by: Sergey B Kirpichev <skirpichev@gmail.com> Adapted from mpmath#639
This pull request is part of the project at sympy/sympy#23926 and also fixes #604.