Remove warnings during windows docker build #8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
February 2, 2021 21:55
…ed runtime - fix an issue when linking thirdparty and sqlite libraries that are build with /MD instead of /MT - CMAKE_MSVC_RUNTIME_LIBRARY is a new feature of CMAKE that is instroduced in 3.15 hence need to up the minimum version - This global property force all projects to build with /MT without needing to change the CXX_FLAGS
…ute on RegistryKey - warning messages says it's safe to remove this attribute.
sfc-gh-mpilman
approved these changes
Feb 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a few of the warning that happen during the build inside Docker.
**: Fixing the static linking issues requires using a new
CMAKE_MSVC_RUNTIME_LIBRARYproperty introduced in CMake 3.15 to help configure the runtime library setting in VS projects. The default value (when unset) isMultiThreadedDLLwhich correspond to dynamic runtime (/MD) but the rest of fdb is build with static linking (/MT). This causes issues with symbols during linking.CMake requires explicitly selecting for a minimum version to enable this new feature, so requiring 3.13 will ignore this setting unfortunately.