Fix #44, Fix #175: show an error when server cannot be changed#205
Merged
Fix #44, Fix #175: show an error when server cannot be changed#205
Conversation
grahamalama
approved these changes
May 7, 2024
alexcottner
reviewed
May 7, 2024
| <option value="dev-preview">Dev (preview)</option> | ||
| <option value="local">Local</option> | ||
| </select> | ||
| <div id="environment-error" class="error">⚠️ Environment cannot be changed. Try running Firefox with environment variable <pre>MOZ_REMOTE_SETTINGS_DEVTOOLS=1</pre></div> |
Contributor
There was a problem hiding this comment.
We're probably gonna have a merge conflict with #209 here.
Contributor
Author
There was a problem hiding this comment.
more seriously, this is pretty trivial to merge into your PR (both html element and css rule are "atomic")
alexcottner
approved these changes
May 7, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #44, Fix #175
Alternative approaches:
allowServerOverridein theRemoteSettings.inspect()response (ie. addUtils.allowServerOverridehere). Clean, but requires to ride trains before being able to use it in the Dev ToolsUtils.sys.jsmin the DevToolsapi.jscode. Less hacky to detect ignored pref change, but would break the current pattern whereRemoteSettings.*is our interface to the internals of Gecko code