Skip to content

extension/experiments/remotesettings/api.js methods do not set bucket #58

@g-k

Description

@g-k

A lot of the methods in extension/experiments/remotesettings/api.js take a bucket param, but do not pass it or the relevant pref to the RemoteSettings constructor.

i.e. we have:

          /**
           * forceSync() will trigger a synchronization at the level only for the specified bucket/collection.
           * @param {String} bucket  bucket name, likely "main"
           * @param {String} collection collection name
           */
          async forceSync(bucket, collection) {
            try {
              const client = RemoteSettings(collection);
...

instead of something like:

    const BUCKET_PREFS = {
        bucketNamePref: "services.settings.security.onecrl.bucket",
        lastCheckTimePref: "services.settings.security.onecrl.checked",
        signerName: "services.settings.security.onecrl.signer",
    };
    const client = RemoteSettings(collection, BUCKET_PREFS);

This might be causing #44 too.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions