fix(travis): Run tests with Node 10 instead of 8#238
Merged
Rob--W merged 3 commits intomozilla:masterfrom Sep 17, 2020
Merged
Conversation
Member
Author
|
Fun. CI keeps failing, now due to Firefox. I'll file a bug upstream. |
0b9cb85 to
c9e7d4d
Compare
CI is currently failing because package.json refers chromedriver ^80.0.1, which also matches 80.0.2. In 80.0.2, chromedriver updated the `extract-zip` dependency: giggio/node-chromedriver@16151de extract-zip 2.0.0 has dropped support for Node <10, e.g. by using APIs that were introduced in Node 10: https://github.com/maxogden/extract-zip/blob/v2.0.0/index.js#L11 which triggers the following error when run on earlier versions of Node: ``` > chromedriver@80.0.2 install /home/travis/build/mozilla/webextension-polyfill/node_modules/chromedriver > node install.js internal/util.js:214 throw new errors.TypeError('ERR_INVALID_ARG_TYPE', 'original', 'function'); ^ TypeError [ERR_INVALID_ARG_TYPE]: The "original" argument must be of type function at promisify (internal/util.js:214:11) at Object.<anonymous> (/home/travis/build/mozilla/webextension-polyfill/node_modules/extract-zip/index.js:11:18) at Module._compile (module.js:653:30) at Object.Module._extensions..js (module.js:664:10) at Module.load (module.js:566:32) at tryModuleLoad (module.js:506:12) at Function.Module._load (module.js:498:3) at Module.require (module.js:597:17) at require (internal/module.js:11:18) at Object.<anonymous> (/home/travis/build/mozilla/webextension-polyfill/node_modules/chromedriver/install.js:14:20) ``` This commit fixes the issue by running tests with Node 10. Node 8 had become end-of-life on 2019-12-31 anyway.
Work-around for upstream regression @ https://bugzilla.mozilla.org/show_bug.cgi?id=1665568
rpl
approved these changes
Sep 17, 2020
c9e7d4d to
d6a789b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CI is currently failing because package.json refers chromedriver
^80.0.1, which also matches 80.0.2.In 80.0.2, chromedriver updated the
extract-zipdependency:giggio/node-chromedriver@16151de
extract-zip 2.0.0 has dropped support for Node <10, e.g. by using APIs that were introduced in Node 10:
https://github.com/maxogden/extract-zip/blob/v2.0.0/index.js#L11
which triggers the following error when run on earlier versions of Node:
This commit fixes the issue by running tests with Node 10.
Node 8 had become end-of-life on 2019-12-31 anyway.
(and node-chromedriver started to officially require Node 10 starting with 83.0.0, in giggio/node-chromedriver#263 )