fix: Android 13 startActivity with correct intent action and category#2734
Merged
willdurand merged 1 commit intomozilla:masterfrom Apr 25, 2023
Merged
Conversation
1efb27d to
536ac6f
Compare
536ac6f to
5be16c1
Compare
willdurand
approved these changes
Apr 25, 2023
Member
willdurand
left a comment
There was a problem hiding this comment.
I updated a test case and added support for Android < 13 builds because this change is in nightly. I verified that web-ext works with: Fenix Release, Fenix Nightly and a Fenix local/debug build.
Member
|
@Rob--W since I updated this PR, could you please take a look too? I'd like to get that fix backported to |
Rob--W
approved these changes
Apr 25, 2023
Member
Rob--W
left a comment
There was a problem hiding this comment.
Confirmed that the adjustment matches the intent-filter from the relevant manifests:
- Fenix - https://github.com/mozilla-mobile/firefox-android/blob/487bc890e4fd221ea90209034c522d54ab237284/fenix/app/src/main/AndroidManifest.xml#L66-L74
- GVE - https://searchfox.org/mozilla-central/rev/1f4f99a8f331cce8467a50742178b6d46914ab89/mobile/android/geckoview_example/src/main/AndroidManifest.xml#24-35 (different name)
- Focus - https://github.com/mozilla-mobile/firefox-android/blob/481768ce88bec0e5a2ae998d0eb7029f4463670a/focus-android/app/src/main/AndroidManifest.xml#L89-L102 (even though it doesn't support extensions)
willdurand
pushed a commit
that referenced
this pull request
Apr 25, 2023
…#2734) Co-authored-by: Zac McKenney <zmckenney@mozilla.com>
renovate bot
referenced
this pull request
in JoshuaKGoldberg/refined-saved-replies
May 31, 2024
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [web-ext](https://togithub.com/mozilla/web-ext) | [`^7.8.0` -> `^8.0.0`](https://renovatebot.com/diffs/npm/web-ext/7.12.0/8.0.0) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>mozilla/web-ext (web-ext)</summary> ### [`v8.0.0`](https://togithub.com/mozilla/web-ext/releases/tag/8.0.0) [Compare Source](https://togithub.com/mozilla/web-ext/compare/7.12.0...8.0.0) #### What's changed 300+ commits have been written to get this new version 8 out of the door (see link to the full changelog at the bottom). Please take a look at the [official documentation](https://extensionworkshop.com/documentation/develop/web-ext-command-reference/) to know what has changed but expect some breaking changes. Specifically, `web-ext sign` has been heavily refactored. Among other things, you can create new add-ons (not just versions) from the command line now 🎉 Unfortunately, this command is not backward compatible with v7. While we're keeping the v7 branch around to ease the transition, we will mainly fix bugs and introduce new features in v8. #### New contributors - [@​zmckenney](https://togithub.com/zmckenney) made their first contribution in [https://github.com/mozilla/web-ext/pull/2734](https://togithub.com/mozilla/web-ext/pull/2734) - [@​uiolee](https://togithub.com/uiolee) made their first contribution in [https://github.com/mozilla/web-ext/pull/2843](https://togithub.com/mozilla/web-ext/pull/2843) - [@​afonsojramos](https://togithub.com/afonsojramos) made their first contribution in [https://github.com/mozilla/web-ext/pull/2760](https://togithub.com/mozilla/web-ext/pull/2760) - [@​lm1](https://togithub.com/lm1) made their first contribution in [https://github.com/mozilla/web-ext/pull/2857](https://togithub.com/mozilla/web-ext/pull/2857) - [@​dotproto](https://togithub.com/dotproto) made their first contribution in [https://github.com/mozilla/web-ext/pull/3111](https://togithub.com/mozilla/web-ext/pull/3111) **Full changelog**: mozilla/web-ext@7.12.0...8.0.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/JoshuaKGoldberg/refined-saved-replies). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4zNzcuOCIsInVwZGF0ZWRJblZlciI6IjM3LjM3Ny44IiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJkZXBlbmRlbmNpZXMiXX0=--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Due to Android 13 changes described here which require activities to now match action and categories this PR updates the
.startActivityto do this.Locally building and testing shows this to now work in Fenix as expected with the command:
web-ext run -t firefox-android --adb-device DEVICE_ID_HERE --firefox-apk org.mozilla.fenix.debug --firefox-apk-component App