Skip to content

bump dependencies and affiliated minor code changes due to API changes#683

Closed
drahnr wants to merge 13 commits intomozilla:masterfrom
drahnr:up-deps
Closed

bump dependencies and affiliated minor code changes due to API changes#683
drahnr wants to merge 13 commits intomozilla:masterfrom
drahnr:up-deps

Conversation

@drahnr
Copy link
Copy Markdown
Collaborator

@drahnr drahnr commented Mar 5, 2020

Extraction from #666

@drahnr drahnr changed the title Upgrade to rust version 1.40 und bump which to version 3.1 Upgrade to rust version 1.40 und bump which to version 3.1 and other dependency updates and related changes Mar 5, 2020
@froydnj
Copy link
Copy Markdown
Contributor

froydnj commented Mar 5, 2020

It looks like this is OK up until the point that lockfile changes got committed?

@drahnr
Copy link
Copy Markdown
Collaborator Author

drahnr commented Mar 6, 2020

turned out to be a lot more grunt work than expected, happy to receive some feedback

@drahnr drahnr changed the title Upgrade to rust version 1.40 und bump which to version 3.1 and other dependency updates and related changes Upgrade to rust version 1.40, bump deps and remove deprecated code Mar 6, 2020
@drahnr
Copy link
Copy Markdown
Collaborator Author

drahnr commented Mar 6, 2020 •
edited
Loading

Includes changes of #537

@drahnr
Copy link
Copy Markdown
Collaborator Author

drahnr commented Mar 9, 2020

@froydnj should be ready for inclusion

@froydnj
Copy link
Copy Markdown
Contributor

froydnj commented Mar 9, 2020

Timeout test failures seem to be intermittent, but this now conflicts with other changes that have landed. Please fix those up.

@drahnr
Copy link
Copy Markdown
Collaborator Author

drahnr commented Mar 9, 2020

@froydnj rebased

@drahnr drahnr force-pushed the up-deps branch 2 times, most recently from 40d670a to c99bfb6 Compare March 9, 2020 14:35
@froydnj
Copy link
Copy Markdown
Contributor

froydnj commented Mar 9, 2020

Looks like there are some CI errors related to the ring crate.

@drahnr
Copy link
Copy Markdown
Collaborator Author

drahnr commented Mar 9, 2020

Fixed

@drahnr drahnr mentioned this pull request Mar 11, 2020
Merged
@drahnr
Copy link
Copy Markdown
Collaborator Author

drahnr commented Mar 13, 2020 •
edited
Loading

please merge this after #666 and after #713

@drahnr drahnr force-pushed the up-deps branch 3 times, most recently from 4028ba9 to 7a69488 Compare March 20, 2020 11:01
@drahnr drahnr changed the title Upgrade to rust version 1.40, bump deps and remove deprecated code bump dependencies and affiliated minor code changes due to API changes Mar 20, 2020
@drahnr
Copy link
Copy Markdown
Collaborator Author

drahnr commented Mar 22, 2020

@chmanchester @ry the apple CI keeps failing sporadically, this time it didn't even start: https://travis-ci.org/github/mozilla/sccache/builds/665235257?utm_source=github_status&utm_medium=notification

@drahnr
Copy link
Copy Markdown
Collaborator Author

drahnr commented Mar 31, 2020

Should be ready for merge

This was referenced Nov 18, 2020
Closed
Closed
@glandium
Copy link
Copy Markdown
Collaborator

glandium commented Dec 10, 2020

I think everything in here is covered with current master, except for
ba3e8b1
I'm going to close this PR, please open a new one for that part if you think it's worth it.

@glandium glandium closed this Dec 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@drahnr @froydnj @glandium