Closed
Conversation
It turns out that redis-rs 0.9.0 doesn't properly handle percent-decoding of passwords extracted from the provided redis URL. This is particularly problematic for Azure-hosted Redis infrastructure, as the access keys that are generated are all base64 encoded (and thus have padding `=` chars) which are percent-encoded when parsed into URL format. Bumping the redis dep handles this use-case. Unfortunately I discovered shortly thereafter that Azure disables the CONFIG command (along with others) for their hosted Redis Cache... Oh well. The update might see some help for someone using non-urlsafe passwords for Redis somewhere.
Contributor
|
Thanks for this change; it looks like there are some conflicts. Can you rebase your changes and force-push your branch again, please? |
Collaborator
tottoto
pushed a commit
to tottoto/sccache
that referenced
this pull request
Feb 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It turns out that redis-rs 0.9.0 doesn't properly handle percent-decoding
of passwords extracted from the provided redis URL. This is particularly
problematic for Azure-hosted Redis infrastructure, as the access keys that
are generated are all base64 encoded (and thus have padding
=chars) whichare percent-encoded when parsed into URL format. Bumping the redis dep handles
this use-case.
Unfortunately I discovered shortly thereafter that Azure disables the CONFIG
command (along with others) for their hosted Redis Cache... Oh well. The update
might see some help for someone using non-urlsafe passwords for Redis somewhere.
Also, if I'm missing some PR guidelines or whatnot sorry about that - just cutting this in the hopes that my frustration might benefit someone else, but it's such a small change I'm sure you could just inline it locally without any fuss.