Remove openssl dependency for GCS#367
Merged
luser merged 3 commits intomozilla:masterfrom Feb 8, 2019
Jake-Shadle:gcs
Merged
Conversation
Contributor
Author
|
Went ahead and removed the now superfluous |
Contributor
|
Thanks for the patch! I'll try to take a look at this today. |
Contributor
|
OK, I'm going to land this as-is. I don't love having crates.io patches because they complicate pushing new releases, but hopefully the jsonwebtoken API situation will get sorted out and we can switch back to an upstream release soon. |
26 tasks
tottoto
pushed a commit
to tottoto/sccache
that referenced
this pull request
Feb 6, 2026
pin-project will deprecate the project attribute due to some unfixable limitations. Refs: taiki-e/pin-project#225
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a slight reimplementation of #272 that I think works slightly better.
pemwhich seems like overkill for just parsing a key out, at least if it's only going to be used for GCS specifically. This just uses a simple string split since the key format is not complicated.