Don't use CARGO_REGISTRIES_* configuration in hash keys#2308
Merged
Xuanwo merged 1 commit intomozilla:mainfrom Jan 4, 2025
Merged
Don't use CARGO_REGISTRIES_* configuration in hash keys#2308Xuanwo merged 1 commit intomozilla:mainfrom
Xuanwo merged 1 commit intomozilla:mainfrom
Conversation
c0bc73a to
8642030
Compare
Xuanwo
approved these changes
Jan 4, 2025
Collaborator
Xuanwo
left a comment
There was a problem hiding this comment.
Makes sense. Thank you @kornelski for this!
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2308 +/- ##
==========================================
- Coverage 30.91% 0 -30.92%
==========================================
Files 53 0 -53
Lines 20112 0 -20112
Branches 9755 0 -9755
==========================================
- Hits 6217 0 -6217
+ Misses 7922 0 -7922
+ Partials 5973 0 -5973 ☔ View full report in Codecov by Sentry. |
tottoto
added a commit
to tottoto/sccache
that referenced
this pull request
Feb 6, 2026
…ozilla#2308) * doc: try to improve the doc-disparity between `tonic-build`'s `lib.rs` and the readme * Fix indentation * fix the doctests * fix a typo and retes an assumption * Change `compile_fail` to `ignore` Co-authored-by: tottoto <tottotodev@gmail.com> --------- Co-authored-by: tottoto <tottotodev@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Private registry configuration in Cargo can be specified using
CARGO_REGISTRIES_$name_*env vars. That it includesCARGO_REGISTRIES_$name_TOKEN, which is an auth secret. The tokens have high entropy and change often, so inclusion of such env vars in the hash key completely ruins caching in sccache.I don't think any of the
CARGO_REGISTRIES_env vars need to be tracked, because Cargo identifies dependencies by their package IDs, which already includes a normalized registry URL. Only the resolved package ID affects the result, not the mechanics of how Cargo discovered it.