Skip to content

Conversation

@craigcook
Copy link
Contributor

@craigcook craigcook commented Mar 11, 2020

Description

Fixes #549 - use border-box
Fix image replacement bug
Add focus styles
Tweak spacing

  • I have documented this change in the design system.
  • I have recorded this change in CHANGELOG.md.

Issue

#549

@craigcook craigcook added Needs:Review 👋 Ready for Developer Review Review: XS Code review time: 30 mins or less labels Mar 11, 2020
Copy link
Contributor

@stephaniehobson stephaniehobson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

R+ the way it is. Nice #a11y improvements.

We could optionally display the focus styles on hover as well.

text-align: center;

@media #{$mq-sm} {
min-width: $content-sm;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥

@stephaniehobson stephaniehobson removed the Needs:Review 👋 Ready for Developer Review label Mar 19, 2020
Fixes mozilla#549 - use border-box
Fix image replacement bug
Add focus styles
Tweak spacing
@craigcook craigcook force-pushed the 549-notification-bar branch from 6b34a51 to de1ca8a Compare March 19, 2020 15:02
@craigcook craigcook merged commit d71eae8 into mozilla:master Mar 19, 2020
@craigcook craigcook deleted the 549-notification-bar branch March 19, 2020 18:09
craigcook added a commit that referenced this pull request May 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Review: XS Code review time: 30 mins or less

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Notification bar should use box-sizing: border-box;

2 participants