Skip to content

Refactors getDocument and adds PDFDataRangeTransport.#5554

Merged
brendandahl merged 1 commit intomozilla:masterfrom
yurydelendik:apiref
Jan 8, 2015
Merged

Refactors getDocument and adds PDFDataRangeTransport.#5554
brendandahl merged 1 commit intomozilla:masterfrom
yurydelendik:apiref

Conversation

@yurydelendik
Copy link
Contributor

@yurydelendik yurydelendik commented Dec 17, 2014

No description provided.

@yurydelendik yurydelendik mentioned this pull request Dec 17, 2014
Closed
@Snuffleupagus
Copy link
Collaborator

Snuffleupagus commented Dec 17, 2014

/botio test

@pdfjsbot
Copy link

pdfjsbot commented Dec 17, 2014

From: Bot.io (Linux)

Received

Command cmd_test from @Snuffleupagus received. Current queue size: 0

Live output at: http://107.21.233.14:8877/f1c739253fa1bcd/output.txt

@pdfjsbot
Copy link

pdfjsbot commented Dec 17, 2014

From: Bot.io (Windows)

Received

Command cmd_test from @Snuffleupagus received. Current queue size: 0

Live output at: http://107.22.172.223:8877/f7211fa8fad75c0/output.txt

@pdfjsbot
Copy link

pdfjsbot commented Dec 17, 2014

From: Bot.io (Windows)

Success

Full output at http://107.22.172.223:8877/f7211fa8fad75c0/output.txt

Total script time: 17.11 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Regression tests: Passed

@pdfjsbot
Copy link

pdfjsbot commented Dec 17, 2014

From: Bot.io (Linux)

Success

Full output at http://107.21.233.14:8877/f1c739253fa1bcd/output.txt

Total script time: 22.43 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Regression tests: Passed

Snuffleupagus
Snuffleupagus reviewed Dec 18, 2014
View reviewed changes
src/display/api.js Outdated
Copy link
Collaborator

@Snuffleupagus Snuffleupagus Dec 18, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: @returns {Promise}.

Copy link
Contributor Author

@yurydelendik yurydelendik Dec 18, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

@yurydelendik yurydelendik force-pushed the apiref branch 2 times, most recently from a19f9f3 to 67e4aa4 Compare December 18, 2014 16:44
@yurydelendik
Copy link
Contributor Author

yurydelendik commented Dec 18, 2014

Fixes #5277

@yurydelendik yurydelendik added this to the 2014 Q4 milestone Dec 19, 2014
Snuffleupagus
Snuffleupagus reviewed Dec 21, 2014
View reviewed changes
src/display/api.js Outdated
Copy link
Collaborator

@Snuffleupagus Snuffleupagus Dec 21, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: copy-and-paste error in the function name RenderTask -> PDFDocumentLoadingTask.

Copy link
Contributor Author

@yurydelendik yurydelendik Dec 22, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

@Snuffleupagus
Copy link
Collaborator

Snuffleupagus commented Dec 22, 2014

Change internalRenderTask -> _internalRenderTask at: https://github.com/mozilla/pdf.js/pull/5554/files#diff-0ecad279ed2252e3eb47a4d96ec1463cR1486.

@yurydelendik
Copy link
Contributor Author

yurydelendik commented Dec 22, 2014

Change internalRenderTask -> _internalRenderTask

Fixed.

brendandahl
brendandahl reviewed Jan 5, 2015
View reviewed changes
src/display/api.js Outdated
Copy link
Contributor

@brendandahl brendandahl Jan 5, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see we used the word "obsolete" before, but "deprecated" really makes more sense for all of these.

Copy link
Contributor Author

@yurydelendik yurydelendik Jan 6, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

brendandahl added a commit that referenced this pull request Jan 8, 2015
@brendandahl
Merge pull request #5554 from yurydelendik/apiref
6ceb652 
Refactors getDocument and adds PDFDataRangeTransport.
@brendandahl brendandahl merged commit 6ceb652 into mozilla:master Jan 8, 2015
@Snuffleupagus Snuffleupagus mentioned this pull request Jan 13, 2015
Merged
speedplane pushed a commit to speedplane/pdf.js that referenced this pull request Feb 24, 2015
@brendandahl
Merge pull request mozilla#5554 from yurydelendik/apiref
2ef56b0 
Refactors getDocument and adds PDFDataRangeTransport.
@yurydelendik yurydelendik deleted the apiref branch January 28, 2016 21:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@brendandahl brendandahl

Labels

core

Projects

None yet

Milestone

2014 Q4

Development

Successfully merging this pull request may close these issues.

5 participants

@yurydelendik @Snuffleupagus @pdfjsbot @brendandahl @timvandermeij