Evaluate type 1 charstrings for conversion to type 2. by brendandahl · Pull Request #2527 · mozilla/pdf.js

brendandahl · 2013-01-04T22:41:16Z

Fixes #1936 and #2536

brendandahl · 2013-01-04T22:41:23Z

/botio test

pdfjsbot · 2013-01-04T22:41:25Z

From: Bot.io (Linux)

Received

Command cmd_test from @brendandahl received. Current queue size: 0

Live output at: http://107.21.233.14:8877/4e4f932c595b47d/output.txt

pdfjsbot · 2013-01-04T22:41:25Z

From: Bot.io (Windows)

Received

Command cmd_test from @brendandahl received. Current queue size: 0

Live output at: http://107.22.172.223:8877/4717b69a4d94365/output.txt

pdfjsbot · 2013-01-04T22:57:09Z

From: Bot.io (Windows)

Failed

Full output at http://107.22.172.223:8877/4717b69a4d94365/output.txt

Total script time: 15.72 mins

Lint: Passed
Font tests: Passed
Unit tests: Passed
Regression tests: FAILED

Image differences available at: http://107.22.172.223:8877/4717b69a4d94365/reftest-analyzer.xhtml#web=eq.log

pdfjsbot · 2013-01-04T23:01:43Z

From: Bot.io (Linux)

Failed

Full output at http://107.21.233.14:8877/4e4f932c595b47d/output.txt

Total script time: 20.30 mins

Lint: Passed
Font tests: Passed
Unit tests: Passed
Regression tests: FAILED

Image differences available at: http://107.21.233.14:8877/4e4f932c595b47d/reftest-analyzer.xhtml#web=eq.log

yurydelendik · 2013-01-08T19:24:57Z

/botio test

pdfjsbot · 2013-01-08T19:25:02Z

From: Bot.io (Windows)

Received

Command cmd_test from @yurydelendik received. Current queue size: 0

Live output at: http://107.22.172.223:8877/8d957686a90618e/output.txt

pdfjsbot · 2013-01-08T19:25:03Z

From: Bot.io (Linux)

Received

Command cmd_test from @yurydelendik received. Current queue size: 0

Live output at: http://107.21.233.14:8877/0394ff4f9c88780/output.txt

pdfjsbot · 2013-01-08T19:40:45Z

From: Bot.io (Windows)

Failed

Full output at http://107.22.172.223:8877/8d957686a90618e/output.txt

Total script time: 15.70 mins

Lint: Passed
Font tests: Passed
Unit tests: Passed
Regression tests: FAILED

Image differences available at: http://107.22.172.223:8877/8d957686a90618e/reftest-analyzer.xhtml#web=eq.log

pdfjsbot · 2013-01-08T19:45:29Z

From: Bot.io (Linux)

Failed

Full output at http://107.21.233.14:8877/0394ff4f9c88780/output.txt

Total script time: 20.43 mins

Lint: Passed
Font tests: Passed
Unit tests: Passed
Regression tests: FAILED

Image differences available at: http://107.21.233.14:8877/0394ff4f9c88780/reftest-analyzer.xhtml#web=eq.log

gigaherz · 2013-01-08T20:31:36Z

You have a circular reference in your "fixes" list, you probably meant #2536 instead of #2527.

yurydelendik · 2013-01-09T16:34:54Z

src/fonts.js

parseFloat / parseInt will convert stuff into strings first, use value === (value | 0)

yurydelendik · 2013-01-09T16:42:22Z

/botio-windows preview

pdfjsbot · 2013-01-09T16:42:32Z

From: Bot.io (Windows)

Received

Command cmd_preview from @yurydelendik received. Current queue size: 0

Live output at: http://107.22.172.223:8877/c33836bc3a892b2/output.txt

pdfjsbot · 2013-01-09T16:42:48Z

From: Bot.io (Windows)

Success

Full output at http://107.22.172.223:8877/c33836bc3a892b2/output.txt

Total script time: 0.26 mins

Published

Viewer: http://107.22.172.223:8877/c33836bc3a892b2/web/viewer.html
Extension: http://107.22.172.223:8877/c33836bc3a892b2/extensions/firefox/pdf.js.xpi
Extension (AMO): http://107.22.172.223:8877/c33836bc3a892b2/extensions/firefox/pdf.js.amo.xpi

yurydelendik · 2013-01-09T16:46:52Z

(Some letters are missing at https://mooculus.osu.edu/textbook/mooculus.pdf, windows hwa on

)

brendandahl · 2013-01-10T01:34:55Z

/botio test

Addressed review comments & disabled hinting.

pdfjsbot · 2013-01-10T01:34:56Z

From: Bot.io (Windows)

Received

Command cmd_test from @brendandahl received. Current queue size: 0

Live output at: http://107.22.172.223:8877/120a5ddbcbc61b6/output.txt

pdfjsbot · 2013-01-10T01:34:57Z

From: Bot.io (Linux)

Received

Command cmd_test from @brendandahl received. Current queue size: 0

Live output at: http://107.21.233.14:8877/95d8f8598124dcb/output.txt

pdfjsbot · 2013-01-10T01:50:42Z

From: Bot.io (Windows)

Failed

Full output at http://107.22.172.223:8877/120a5ddbcbc61b6/output.txt

Total script time: 15.75 mins

Lint: Passed
Font tests: Passed
Unit tests: Passed
Regression tests: FAILED

Image differences available at: http://107.22.172.223:8877/120a5ddbcbc61b6/reftest-analyzer.xhtml#web=eq.log

pdfjsbot · 2013-01-10T01:55:06Z

From: Bot.io (Linux)

Failed

Full output at http://107.21.233.14:8877/95d8f8598124dcb/output.txt

Total script time: 20.15 mins

Lint: Passed
Font tests: Passed
Unit tests: Passed
Regression tests: FAILED

Image differences available at: http://107.21.233.14:8877/95d8f8598124dcb/reftest-analyzer.xhtml#web=eq.log

yurydelendik · 2013-01-26T13:57:59Z

/botio test

pdfjsbot · 2013-01-26T13:58:01Z

From: Bot.io (Windows)

Received

Command cmd_test from @yurydelendik received. Current queue size: 1

Live output at: http://107.22.172.223:8877/9cc24c72ca8cb17/output.txt

pdfjsbot · 2013-01-26T13:58:01Z

From: Bot.io (Linux)

Received

Command cmd_test from @yurydelendik received. Current queue size: 1

Live output at: http://107.21.233.14:8877/afd3fb4137e3253/output.txt

pdfjsbot · 2013-01-26T14:32:33Z

From: Bot.io (Windows)

Failed

Full output at http://107.22.172.223:8877/9cc24c72ca8cb17/output.txt

Total script time: 17.50 mins

Lint: Passed
Font tests: Passed
Unit tests: Passed
Regression tests: FAILED

Image differences available at: http://107.22.172.223:8877/9cc24c72ca8cb17/reftest-analyzer.xhtml#web=eq.log

pdfjsbot · 2013-01-26T14:43:01Z

From: Bot.io (Linux)

Failed

Full output at http://107.21.233.14:8877/afd3fb4137e3253/output.txt

Total script time: 22.80 mins

Lint: Passed
Font tests: Passed
Unit tests: Passed
Regression tests: FAILED

Image differences available at: http://107.21.233.14:8877/afd3fb4137e3253/reftest-analyzer.xhtml#web=eq.log

yurydelendik · 2013-01-26T14:49:34Z

/botio makeref

pdfjsbot · 2013-01-26T14:49:36Z

From: Bot.io (Windows)

Received

Command cmd_makeref from @yurydelendik received. Current queue size: 0

Live output at: http://107.22.172.223:8877/edda1072a3b9d5e/output.txt

pdfjsbot · 2013-01-26T14:49:36Z

From: Bot.io (Linux)

Received

Command cmd_makeref from @yurydelendik received. Current queue size: 0

Live output at: http://107.21.233.14:8877/e3cbb535e0fe503/output.txt

pdfjsbot · 2013-01-26T15:06:47Z

From: Bot.io (Windows)

Success

Full output at http://107.22.172.223:8877/edda1072a3b9d5e/output.txt

Total script time: 17.18 mins

Lint: Passed
Make references: Passed
Check references: Passed

pdfjsbot · 2013-01-26T15:11:56Z

From: Bot.io (Linux)

Success

Full output at http://107.21.233.14:8877/e3cbb535e0fe503/output.txt

Total script time: 22.32 mins

Lint: Passed
Make references: Passed
Check references: Passed

Evaluate type 1 charstrings for conversion to type 2.

I think it should have been removed with mozilla#2527 so it should be useless now. Because of that stuff, some commands with a wrong number of arguments weren't stripped out (see the pdf in mozilla#13850).

brendandahl mentioned this pull request Jan 8, 2013

lots of issues with this doc #2536

Closed

yurydelendik reviewed Jan 9, 2013
View reviewed changes

src/fonts.js Outdated

Copy link

Contributor

yurydelendik Jan 9, 2013

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

parseFloat / parseInt will convert stuff into strings first, use value === (value | 0)

Evaluate type 1 charstrings for conversion to type 2.

b5278c5

brendandahl mentioned this pull request Jan 16, 2013

Bad font hinting compared to Adobe Reader #2349

Closed

yurydelendik added a commit that referenced this pull request Jan 26, 2013

Merge pull request #2527 from brendandahl/type1-charstrings

df731e7

Evaluate type 1 charstrings for conversion to type 2.

yurydelendik merged commit df731e7 into mozilla:master Jan 26, 2013

yurydelendik mentioned this pull request Jan 26, 2013

Fixes CFF parser failure when CharStrings contains cntrmask #2615

Merged

calixteman mentioned this pull request Dec 27, 2025

Remove undefStack stuff in the cff parser #20537

Merged

Conversation

brendandahl commented Jan 4, 2013

Uh oh!

brendandahl commented Jan 4, 2013

Uh oh!

pdfjsbot commented Jan 4, 2013

From: Bot.io (Linux)

Received

Uh oh!

pdfjsbot commented Jan 4, 2013

From: Bot.io (Windows)

Received

Uh oh!

pdfjsbot commented Jan 4, 2013

From: Bot.io (Windows)

Failed

Uh oh!

pdfjsbot commented Jan 4, 2013

From: Bot.io (Linux)

Failed

Uh oh!

yurydelendik commented Jan 8, 2013

Uh oh!

pdfjsbot commented Jan 8, 2013

From: Bot.io (Windows)

Received

Uh oh!

pdfjsbot commented Jan 8, 2013

From: Bot.io (Linux)

Received

Uh oh!

pdfjsbot commented Jan 8, 2013

From: Bot.io (Windows)

Failed

Uh oh!

pdfjsbot commented Jan 8, 2013

From: Bot.io (Linux)

Failed

Uh oh!

gigaherz commented Jan 8, 2013

Uh oh!

yurydelendik Jan 9, 2013

Choose a reason for hiding this comment

Uh oh!

yurydelendik commented Jan 9, 2013

Uh oh!

pdfjsbot commented Jan 9, 2013

From: Bot.io (Windows)

Received

Uh oh!

pdfjsbot commented Jan 9, 2013

From: Bot.io (Windows)

Success

Published

Uh oh!

yurydelendik commented Jan 9, 2013

Uh oh!

brendandahl commented Jan 10, 2013

Uh oh!

pdfjsbot commented Jan 10, 2013

From: Bot.io (Windows)

Received

Uh oh!

pdfjsbot commented Jan 10, 2013

From: Bot.io (Linux)

Received

Uh oh!

pdfjsbot commented Jan 10, 2013

From: Bot.io (Windows)

Failed

Uh oh!

pdfjsbot commented Jan 10, 2013

From: Bot.io (Linux)

Failed

Uh oh!

yurydelendik commented Jan 26, 2013

Uh oh!

pdfjsbot commented Jan 26, 2013

From: Bot.io (Windows)

Received