Skip to content

Interpret empty annotation border as [0, 0, 0]#20948

Merged
timvandermeij merged 1 commit intomozilla:masterfrom
calixteman:issue20914
Mar 22, 2026
Merged

Interpret empty annotation border as [0, 0, 0]#20948
timvandermeij merged 1 commit intomozilla:masterfrom
calixteman:issue20914

Conversation

@calixteman
Copy link
Copy Markdown
Contributor

@calixteman calixteman commented Mar 22, 2026

It fixes #20914.

@timvandermeij
Copy link
Copy Markdown
Contributor

timvandermeij commented Mar 22, 2026

/botio-linux preview

timvandermeij
timvandermeij requested changes Mar 22, 2026
View reviewed changes
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Mar 22, 2026 •
edited
Loading

Codecov Report

❌ Patch coverage is 66.66667% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 62.58%. Comparing base (869f25a) to head (de48af7).
⚠️ Report is 6 commits behind head on master.

Files with missing lines Patch % Lines
src/core/annotation.js 66.66% 4 Missing ⚠️
Additional details and impacted files 
@@           Coverage Diff           @@
##           master   #20948   +/-   ##
=======================================
  Coverage   62.57%   62.58%           
=======================================
  Files         174      174           
  Lines      121933   121951   +18     
=======================================
+ Hits        76305    76325   +20     
+ Misses      45628    45626    -2
Flag Coverage Δ
fonttest 7.66% <ø> (ø)
unittestcli 62.56% <66.66%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@mozilla mozilla deleted a comment from moz-tools-bot Mar 22, 2026
@mozilla mozilla deleted a comment from moz-tools-bot Mar 22, 2026
@timvandermeij
Copy link
Copy Markdown
Contributor

timvandermeij commented Mar 22, 2026

/botio-linux preview

@moz-tools-bot
Copy link
Copy Markdown
Collaborator

moz-tools-bot commented Mar 22, 2026

From: Bot.io (Linux m4)

Received

Command cmd_preview from @timvandermeij received. Current queue size: 1

Live output at: http://54.241.84.105:8877/0307b8b42edb80b/output.txt

@moz-tools-bot
Copy link
Copy Markdown
Collaborator

moz-tools-bot commented Mar 22, 2026

From: Bot.io (Linux m4)

Success

Full output at http://54.241.84.105:8877/0307b8b42edb80b/output.txt

Total script time: 1.19 mins

Published

@timvandermeij
Copy link
Copy Markdown
Contributor

timvandermeij commented Mar 22, 2026

r=me, with passing tests. Thanks!

@timvandermeij
Copy link
Copy Markdown
Contributor

timvandermeij commented Mar 22, 2026

/botio test

@moz-tools-bot
Copy link
Copy Markdown
Collaborator

moz-tools-bot commented Mar 22, 2026

From: Bot.io (Linux m4)

Received

Command cmd_test from @timvandermeij received. Current queue size: 0

Live output at: http://54.241.84.105:8877/7f18d8250fcda1a/output.txt

@moz-tools-bot
Copy link
Copy Markdown
Collaborator

moz-tools-bot commented Mar 22, 2026

From: Bot.io (Windows)

Received

Command cmd_test from @timvandermeij received. Current queue size: 1

Live output at: http://54.193.163.58:8877/46ced25df2df943/output.txt

@moz-tools-bot
Copy link
Copy Markdown
Collaborator

moz-tools-bot commented Mar 22, 2026

From: Bot.io (Linux m4)

Success

Full output at http://54.241.84.105:8877/7f18d8250fcda1a/output.txt

Total script time: 46.02 mins

  • Unit tests: Passed
  • Integration Tests: Passed
  • Regression tests: Passed

@moz-tools-bot
Copy link
Copy Markdown
Collaborator

moz-tools-bot commented Mar 22, 2026

From: Bot.io (Windows)

Success

Full output at http://54.193.163.58:8877/46ced25df2df943/output.txt

Total script time: 72.93 mins

  • Unit tests: Passed
  • Integration Tests: Passed
  • Regression tests: Passed

@timvandermeij timvandermeij merged commit 0a6894d into mozilla:master Mar 22, 2026
15 checks passed
@timvandermeij
Copy link
Copy Markdown
Contributor

timvandermeij commented Mar 22, 2026

/botio makeref

@moz-tools-bot
Copy link
Copy Markdown
Collaborator

moz-tools-bot commented Mar 22, 2026

From: Bot.io (Linux m4)

Received

Command cmd_makeref from @timvandermeij received. Current queue size: 0

Live output at: http://54.241.84.105:8877/60c713ecad15e2d/output.txt

@moz-tools-bot
Copy link
Copy Markdown
Collaborator

moz-tools-bot commented Mar 22, 2026

From: Bot.io (Windows)

Received

Command cmd_makeref from @timvandermeij received. Current queue size: 0

Live output at: http://54.193.163.58:8877/d67e498553c25e2/output.txt

@moz-tools-bot
Copy link
Copy Markdown
Collaborator

moz-tools-bot commented Mar 22, 2026

From: Bot.io (Linux m4)

Success

Full output at http://54.241.84.105:8877/60c713ecad15e2d/output.txt

Total script time: 18.69 mins

  • Make references: Passed
  • Check references: Passed

@moz-tools-bot
Copy link
Copy Markdown
Collaborator

moz-tools-bot commented Mar 22, 2026

From: Bot.io (Windows)

Success

Full output at http://54.193.163.58:8877/d67e498553c25e2/output.txt

Total script time: 25.09 mins

  • Make references: Passed
  • Check references: Passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@timvandermeij timvandermeij timvandermeij approved these changes

Assignees

No one assigned

Labels

annotations

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Bug]: Unexpected yellow rectangle artifacts around components in specific PDF schematic

4 participants

@calixteman @timvandermeij @codecov-commenter @moz-tools-bot