Skip to content

Fix the position of 'Attachments' in the sidebar#20895

Merged
calixteman merged 1 commit intomozilla:masterfrom
calixteman:issue20893
Mar 18, 2026
Merged

Fix the position of 'Attachments' in the sidebar#20895
calixteman merged 1 commit intomozilla:masterfrom
calixteman:issue20893

Conversation

@calixteman
Copy link
Copy Markdown
Contributor

@calixteman calixteman commented Mar 16, 2026

It fixes #20893.

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Mar 16, 2026 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 62.63%. Comparing base (0ee557c) to head (44f4627).
⚠️ Report is 92 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master   #20895      +/-   ##
==========================================
- Coverage   62.66%   62.63%   -0.04%     
==========================================
  Files         173      173              
  Lines      121496   121496              
==========================================
- Hits        76140    76101      -39     
- Misses      45356    45395      +39
Flag Coverage Δ
fonttest ?
unittestcli 62.63% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Snuffleupagus
Copy link
Copy Markdown
Collaborator

Snuffleupagus commented Mar 16, 2026

/botio-linux preview

@moz-tools-bot
Copy link
Copy Markdown
Collaborator

moz-tools-bot commented Mar 16, 2026

From: Bot.io (Linux m4)

Received

Command cmd_preview from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.241.84.105:8877/63f00be3e00cfee/output.txt

@moz-tools-bot
Copy link
Copy Markdown
Collaborator

moz-tools-bot commented Mar 16, 2026

From: Bot.io (Linux m4)

Success

Full output at http://54.241.84.105:8877/63f00be3e00cfee/output.txt

Total script time: 1.30 mins

Published

@Snuffleupagus
Copy link
Copy Markdown
Collaborator

Snuffleupagus commented Mar 16, 2026 •
edited
Loading

This looks much better, however I have one question:
It appears that the "Attachments" and "Layers" titles are centred around a "different point" than the "Pages" title, since there an invisible element (viewsManagerAddFileButton) is affecting layout as well. Is that intended, since what centred means now varies between sidebarViews, or should all sidebarViews perhaps "reserve" space for a button there?

@Snuffleupagus
Copy link
Copy Markdown
Collaborator

Snuffleupagus commented Mar 18, 2026

/botio-linux preview

@moz-tools-bot
Copy link
Copy Markdown
Collaborator

moz-tools-bot commented Mar 18, 2026

From: Bot.io (Linux m4)

Received

Command cmd_preview from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.241.84.105:8877/fa6f2518b093fe2/output.txt

@moz-tools-bot
Copy link
Copy Markdown
Collaborator

moz-tools-bot commented Mar 18, 2026

From: Bot.io (Linux m4)

Success

Full output at http://54.241.84.105:8877/fa6f2518b093fe2/output.txt

Total script time: 1.21 mins

Published

Snuffleupagus
Snuffleupagus approved these changes Mar 18, 2026
View reviewed changes
Copy link
Copy Markdown
Collaborator

@Snuffleupagus Snuffleupagus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks much better and more consistent.

r=me, thank you.

@calixteman calixteman merged commit 979d9c3 into mozilla:master Mar 18, 2026
13 checks passed
@calixteman calixteman deleted the issue20893 branch March 18, 2026 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Snuffleupagus Snuffleupagus Snuffleupagus approved these changes

Assignees

No one assigned

Labels

viewer

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Bug]: The "Attachments" and "Layers" labels are right-aligned in the sidebar toolbar

5 participants

@calixteman @codecov-commenter @Snuffleupagus @moz-tools-bot @timvandermeij