Merged
Conversation
Collaborator
|
@wusyong, could you update your patch to take into account: #427 (comment) ? |
added 2 commits
May 6, 2020 01:11
marco-c
reviewed
May 6, 2020
Collaborator
marco-c
left a comment
There was a problem hiding this comment.
Even if we don't have Rust doc tests, please add RUSTDOCFLAGS too so users of grcov know that it's needed.
marco-c
approved these changes
May 6, 2020
Minoru
added a commit
to newsboat/newsboat
that referenced
this pull request
May 8, 2020
`-Zno-landing-pads` got deprecated. This commit replaces it with options suggested by grcov project: mozilla/grcov#428 Fixes #916.
This was referenced May 8, 2020
Minoru
added a commit
to newsboat/newsboat
that referenced
this pull request
May 11, 2020
`-Zno-landing-pads` got deprecated. This commit replaces it with options suggested by grcov project: mozilla/grcov#428 Fixes #916.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #427
Remove
-Zno-landing-padsin README instructions and CI files since this flag is no longer exist.