This repository was archived by the owner on Jul 9, 2025. It is now read-only.
Unify USSD and MMI promise behaviour#70
Closed
bchabod wants to merge 5 commits intomozilla:masterfrom
Closed
Conversation
Contributor
|
Hi Ben, Here's some context about the current USSD API design. We need to rely on an additional way to notify gaia "ussd responses" because the responses are coming from distinct unsolicited events per android ril.h[1]. Hence, it lacks a determined link b/w the response and a request. So App needs to rely on "ussd-received" notification. Previous discussion here [2]. [1] http://androidxref.com/5.1.1_r6/xref/hardware/ril/include/telephony/ril.h#2195 |
8bf12ad to
3d6d069
Compare
A few errors had to be addressed : - session.send() and session.cancel() promises have to be solved with MMICall and not void - We should clear the current USSD callback before calling it - session.send() and session.cancel() promises weren't binded correctly - We should check for a errorMsg attribute on response object only if it's not null
|
Please do not file PRs here, see https://developer.mozilla.org/docs/Mozilla/Developer_guide/How_to_Submit_a_Patch |
bvaughn
pushed a commit
to bvaughn/gecko-dev
that referenced
this pull request
Apr 5, 2022
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Background:
MMI code = any code you enter on your phone with * or #
USSD code = MMI code that doesn't only access the phone's hardware and requires a response from the operator
Here is how you currently send a MMI code from gaia:
It should be possible to do the same thing for a USSD code.
However, currently, the promise is resolved instantly with an empty result if the message is sent correctly, and the real response comes later, in a system message:
Please note that USSD responses can also contain an object called USSDSession, that you can use to cancel or reply to a dialogue with the operator, which usually looks like a menu.
This PR tries to do the following: