Add the ability to do JSON escaping of printed file and function names. #6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
gabrielesvelto
requested changes
Nov 21, 2019
Collaborator
gabrielesvelto
left a comment
There was a problem hiding this comment.
Looking good save for one small change.
This is necessary for DMD, which puts file names and function names within JSON strings. For testing I had to add a new test binary with the awkward name of `example"json`, which requires escaping of the '"' char.
gabrielesvelto
pushed a commit
to gabrielesvelto/fix-stacks
that referenced
this pull request
Feb 3, 2021
New dump_syms for windows
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is necessary for DMD, which puts file names and function names
within JSON strings.
For testing I had to add a new test binary with the awkward name of
example"json, which requires escaping of the '"' char.