Fix windows breakpad support #19
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because this is the usual naming convention on Windows, and will make Breakpad symbols testing on Windows easier.
It turns out that the directory structure used on Windows is a little different to that used on Mac and Linux.
Because the directory structure is a little different to Linux/Mac.
gabrielesvelto
approved these changes
Mar 13, 2020
Contributor
Author
|
Thank you for the fast review. |
gabrielesvelto
pushed a commit
to gabrielesvelto/fix-stacks
that referenced
this pull request
Feb 3, 2021
* Fix some issues when dumping symbols * Fix nits
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It turns out that the directory structure used on Windows is a little different to that used on Mac and Linux.
r? @gabrielesvelto