Add support for Breakpad symbols. #16
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This involves: - A new option: `-b`/`--breakpad`, for specifying the Breakpad symbols directory. - Code for finding particular `.sym` files within that directory. - Adding a space before the address in output lines, so they don't match the input regexp and thus won't be double processed. - A new test, `test_breakpad`.
gabrielesvelto
approved these changes
Mar 10, 2020
Collaborator
gabrielesvelto
left a comment
There was a problem hiding this comment.
LGTM but we'll have to figure out how to make sure we enforce the one-uuid-per-object constraint when we invoke the script.
Contributor
Author
|
@gabrielesvelto: I have added a second commit that handles multiple uuids. Please review! Thanks. |
gabrielesvelto
approved these changes
Mar 11, 2020
Collaborator
gabrielesvelto
left a comment
There was a problem hiding this comment.
LGTM but open an issue to get rid of the dependency on fileid when it's feasible to do so.
Comment on lines
+377
to
+381
| let output = Command::new(fileid_exe) | ||
| .arg(&bin_file) | ||
| .output() | ||
| .map_err(|_| format!("run `{}` for", fileid_exe))?; | ||
| let uuid = str::from_utf8(&output.stdout).unwrap().trim_end(); |
Collaborator
There was a problem hiding this comment.
I'm still amazed at how concise Rust can be. Doing this stuff in C/C++ would be at least 100+ lines.
Contributor
Author
|
I opened #18 for removing the dependence on |
xeonchen
pushed a commit
to xeonchen/gecko
that referenced
this pull request
Mar 16, 2020
…svelto This uses `fix-stacks`'s new Breakpad symbols support from mozilla/fix-stacks#16. The patch also updates some comments in `dmd.py` to account for some very slight changes in `fix-stacks`'s output. Differential Revision: https://phabricator.services.mozilla.com/D66363
moz-v2v-gh
pushed a commit
to mozilla/gecko-dev
that referenced
this pull request
Mar 16, 2020
…svelto This uses `fix-stacks`'s new Breakpad symbols support from mozilla/fix-stacks#16. The patch also updates some comments in `dmd.py` to account for some very slight changes in `fix-stacks`'s output. Differential Revision: https://phabricator.services.mozilla.com/D66363 --HG-- extra : moz-landing-system : lando
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified-and-comments-removed
that referenced
this pull request
Mar 16, 2020
…svelto This uses `fix-stacks`'s new Breakpad symbols support from mozilla/fix-stacks#16. The patch also updates some comments in `dmd.py` to account for some very slight changes in `fix-stacks`'s output. Differential Revision: https://phabricator.services.mozilla.com/D66363 UltraBlame original commit: 10998b6bf6d86d1201bdc9c0027154cf42970315
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-comments-removed
that referenced
this pull request
Mar 16, 2020
…svelto This uses `fix-stacks`'s new Breakpad symbols support from mozilla/fix-stacks#16. The patch also updates some comments in `dmd.py` to account for some very slight changes in `fix-stacks`'s output. Differential Revision: https://phabricator.services.mozilla.com/D66363 UltraBlame original commit: 10998b6bf6d86d1201bdc9c0027154cf42970315
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified
that referenced
this pull request
Mar 16, 2020
…svelto This uses `fix-stacks`'s new Breakpad symbols support from mozilla/fix-stacks#16. The patch also updates some comments in `dmd.py` to account for some very slight changes in `fix-stacks`'s output. Differential Revision: https://phabricator.services.mozilla.com/D66363 UltraBlame original commit: 10998b6bf6d86d1201bdc9c0027154cf42970315
gabrielesvelto
pushed a commit
to gabrielesvelto/fix-stacks
that referenced
this pull request
Feb 3, 2021
…ng it have IMAGE_SCN_CNT_CODE or IMAGE_SCN_MEM_EXECUTE flags (mozilla#16)
bhearsum
pushed a commit
to mozilla-releng/staging-firefox
that referenced
this pull request
May 1, 2025
…svelto This uses `fix-stacks`'s new Breakpad symbols support from mozilla/fix-stacks#16. The patch also updates some comments in `dmd.py` to account for some very slight changes in `fix-stacks`'s output. Differential Revision: https://phabricator.services.mozilla.com/D66363
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This involves:
-b/--breakpad, for specifying the Breakpad symbolsdirectory.
.symfiles within that directory.the input regexp and thus won't be double processed.
test_breakpad.r? @gabrielesvelto