Fix JSON handling more #14
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In JSON mode, an input filename like `c:\\foo\\bar\\baz` currently isn't unescaped. This has two effects. - Lookup will use `c:\\foo\\bar\\baz` instead of `c:\foo\bar\baz`. This doesn't cause problems because repeated separators are treated the same as single separators, but it is clumsy. - If the file has errors, error messages will say `c:\\foo\\bar\\baz` rather than `c:\foo\bar\baz`. Again, understandable but clumsy. This commit fixes this by unescaping input filenames in JSON mode.
Contributor
Author
|
@gabrielesvelto: And once again, I already landed this because I needed it in a hurry for https://bugzilla.mozilla.org/show_bug.cgi?id=1604095, but I'd be interested to hear if you have any review comments. Thanks. |
Collaborator
|
LGTM just like the previous fix. I ran myself into this kind of stuff when dealing with JSON in crash annotations and it's always annoying to have to selectively unescape stuff. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I missed some cases in #13.