Fix JSON handling #13
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
They currently don't test file errors because the regex doesn't match!
When `-j` is specified, any new strings produced by `fix-stacks` need JSON escaping. However, any strings that come from the input and are reused will already be escaped, and so should not be re-escaped. This commit removes some erroneous escaping of input strings. As a result, some Windows paths no longer get their backslashes escaped twice.
Contributor
Author
|
@gabrielesvelto: Like in #12, I already landed this because I needed it in a hurry for https://bugzilla.mozilla.org/show_bug.cgi?id=1604095, but I'd be interested to hear if you have any review comments. Thanks. |
Merged
gabrielesvelto
pushed a commit
to gabrielesvelto/fix-stacks
that referenced
this pull request
Feb 3, 2021
* A string table isn't mandatory * Add a test with a pdb with no string table
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently some output can be double-escaped.