Initial Linux support. #1
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
gabrielesvelto
requested changes
Nov 15, 2019
Collaborator
gabrielesvelto
left a comment
There was a problem hiding this comment.
Looking good but I'd like the fix() function split up for better readability. On a side note: this is so much better than the existing fix_linux_stack.py script.
Mac and Windows are to be done later.
Contributor
Author
|
Thank you for the comments. I filed the issues you suggested and created new functions in most of the places you suggested, though there were a couple where it didn't work out as well so I left those unchanged. |
gabrielesvelto
pushed a commit
to gabrielesvelto/fix-stacks
that referenced
this pull request
Feb 3, 2021
Get some info from PE
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mac and Windows are to be done later.