fix #9651 feat(nimbus): api v6 uses actual enrollment end date or null #9656
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaredlockhart
approved these changes
Nov 1, 2023
Collaborator
jaredlockhart
left a comment
There was a problem hiding this comment.
Oh yeah, thank you @mikewilli 👍 Can we safely land this first and then make changes to jetstream or do we need to do it the other way around?
Also there's a better pattern for doing this but we'd need to move a bunch of methods around so we can just do it as a followup.
Contributor
Author
|
Yep, it will be safe for Jetstream this way -- the only thing Jetstream will need to change after this is to remove the |
This was referenced Nov 2, 2023
jeddai
pushed a commit
to jeddai/experimenter
that referenced
this pull request
Nov 6, 2023
… or null (mozilla#9656) Because - Cirrus uses continuous enrollment (i.e., enrollment can't end until the experiment does) - Jetstream requires an end for enrollment before the experiment ends for analysis - We can't set `isEnrollmentPaused` to true without prematurely ending the experiment in Cirrus context This commit - Adds an `actual_enrollment_end_date` field to the NimbusExperiment model - uses `actual_enrollment_end_date` for the serialized `enrollmentEndDate` in API v6
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because
isEnrollmentPausedto true without prematurely ending the experiment in Cirrus contextThis commit
actual_enrollment_end_datefield to the NimbusExperiment modelactual_enrollment_end_datefor the serializedenrollmentEndDatein API v6