feat(nimbus): Explicitly require a manifest path in AppConfig #9623
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9018904 to
462ff2a
Compare
462ff2a to
274132f
Compare
274132f to
9403199
Compare
jaredlockhart
approved these changes
Nov 1, 2023
Collaborator
jaredlockhart
left a comment
There was a problem hiding this comment.
Yep looks good thnx @brennie 🎉
jeddai
pushed a commit
to jeddai/experimenter
that referenced
this pull request
Nov 6, 2023
…a#9623) Because - we want to ensure that apps.yaml is always valid; and - we want to ensure that each app specifies exactly one manifest file This commit - adds a test that loads the production apps.yaml; - updates the AppConfig model with a validator to ensure only one manifest path can be specified
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because
This commit
manifest path can be specified