Skip to content

Refactored Warehouse ROS for pluginlib#22

Closed
TheBrewCrew wants to merge 1 commit intomoveit:jade-develfrom
TheBrewCrew:jade-devel
Closed

Refactored Warehouse ROS for pluginlib#22
TheBrewCrew wants to merge 1 commit intomoveit:jade-develfrom
TheBrewCrew:jade-devel

Conversation

@TheBrewCrew
Copy link
Copy Markdown
Contributor

This factors out all MongoDB code into a separate package, warehouse_ros_mongo, and creates an abstraction for warehouse clients to use so that warehouse_ros can be built for non LTS versions of Ubuntu and Jade. Pluginlib is used to load the Mongo code dynamically.

@isucan
Copy link
Copy Markdown
Contributor

isucan commented Aug 31, 2015

Changes look good, thanks for doing this! The travis build fails here though.

@mikeferguson
Copy link
Copy Markdown
Contributor

@isucan Travis won't work for Jade (since it is trusty+ and travis only supports precise).

@mikeferguson
Copy link
Copy Markdown
Contributor

Also, once this and the other PR are merged, we will want to move https://github.com/TheBrewCrew/warehouse_ros_mongo into the organization as it is the home of the new plugin for mongodb.

@vrabaud
Copy link
Copy Markdown
Contributor

vrabaud commented Sep 22, 2015

can we move forward on this one ? Robot specific moveit packages cannot be released on Jade because of that. Thx

@marcoesposito1988
Copy link
Copy Markdown

I quote that. At least Mongo is made optional and the rest of MoveIt can be used.

@mikeferguson
Copy link
Copy Markdown
Contributor

I'm planning to have time this weekend to make a pass through these and some others and get stuff building/released in Jade

@vrabaud
Copy link
Copy Markdown
Contributor

vrabaud commented Sep 25, 2015

@mikeferguson , this would be important for a personal project: I can help this weekend on stupid build issues (or release, just grant me rights there if needed and I can commit / trigger builds). Thx !

@marcoesposito1988
Copy link
Copy Markdown

ping?

@vrabaud
Copy link
Copy Markdown
Contributor

vrabaud commented Feb 3, 2016

Travis now supports Trusty so please re-enable. E.g.
https://github.com/ros-perception/vision_opencv/blob/indigo/.travis.yml

@anderwm
Copy link
Copy Markdown

anderwm commented Mar 9, 2016

Not sure if I am missing something or if this still isn't done yet: With brewCrew's code I still cannot build moveIt for Jade on Vivid. I get the "variables used but set to not found". Am I using it wrong or is this not yet a functional work around?

@130s 130s mentioned this pull request Apr 16, 2016
@130s
Copy link
Copy Markdown
Contributor

130s commented Apr 20, 2016

Travis now supports Trusty so please re-enable. E.g. https://github.com/ros-perception/vision_opencv/blob/indigo/.travis.yml

I'm trying to adjust Travis for Trusty in #26.

@davetcoleman
Copy link
Copy Markdown
Member

i just restarted travis for this PR

@130s
Copy link
Copy Markdown
Contributor

130s commented Jun 16, 2016

This PR:

  • is conflicted
    
  • contains some undesired removal (changelog, .travis.yml)
  • and yes, travis isn't triggered properly.

Let's move on to #32 that I re-opened this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants