Skip to content

Enable tests for Jade#26

Closed
130s wants to merge 11 commits intomoveit:masterfrom
130s:impr/travis_trusty
Closed

Enable tests for Jade#26
130s wants to merge 11 commits intomoveit:masterfrom
130s:impr/travis_trusty

Conversation

@130s
Copy link
Copy Markdown
Contributor

@130s 130s commented Apr 16, 2016

To address an existing issue like #22 (comment)

As noted in-file already, mongo hack is already implemented in the depended script.

@130s
Copy link
Copy Markdown
Contributor Author

130s commented Apr 16, 2016 •
edited
Loading

Travis fails, probably because the test cases are not configured to run ROS master.
With the current Travis config file, some tests were successful because there's no test phase (last line is catkin_make -j2).

Choice is to either improve test cases or to drop testing phase in the proposed Travis config. I obviously am inclined to the former option.

@130s 130s force-pushed the impr/travis_trusty branch 2 times, most recently from 761d69e to 5fb162e Compare April 16, 2016 22:22
@130s 130s force-pushed the impr/travis_trusty branch from 5fb162e to e2b2db8 Compare April 20, 2016 05:20
@130s 130s force-pushed the impr/travis_trusty branch 2 times, most recently from a1ac89e to dd96acf Compare April 20, 2016 15:38
@130s 130s force-pushed the impr/travis_trusty branch from dd96acf to 31acfcc Compare April 20, 2016 15:45
@130s
Copy link
Copy Markdown
Contributor Author

130s commented Apr 20, 2016

Adding gtest hasn't been successful, even on Indigo. I've asked a question.

@130s 130s mentioned this pull request Apr 20, 2016
Closed
dirk-thomas
dirk-thomas reviewed Apr 20, 2016
View reviewed changes
CMakeLists.txt Outdated
rostime
std_msgs)
if (CATKIN_ENABLE_TESTING)
find_package(catkin REQUIRED COMPONENTS rostest)
Copy link
Copy Markdown
Contributor

@dirk-thomas dirk-thomas Apr 20, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will overwrite the variable starting with catkin_ which is likely not working since the packages found above won't be part of catkin_INCLUDE_DIRS and catkin_LIBRARIES anymore.

Instead use find_package(rostest REQUIRED).

@130s 130s force-pushed the impr/travis_trusty branch from 9518a56 to 2951e5f Compare April 20, 2016 21:35
@130s 130s mentioned this pull request Apr 21, 2016
Merged
@130s 130s changed the title [CI] Update Travis conf for Trusty Enable tests for Jade Apr 21, 2016
@130s
Copy link
Copy Markdown
Contributor Author

130s commented Apr 21, 2016

Closing in favor of #28 that is targetted to the correct branch.

@130s 130s closed this Apr 21, 2016
@130s 130s deleted the impr/travis_trusty branch April 21, 2016 00:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@130s @dirk-thomas