Stage::reset() should reset total_compute_time_#310
Merged
JafarAbdi merged 1 commit intomoveit:masterfrom Nov 25, 2021
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #310 +/- ##
==========================================
+ Coverage 52.99% 53.00% +0.01%
==========================================
Files 102 102
Lines 7598 7599 +1
==========================================
+ Hits 4026 4027 +1
Misses 3572 3572
Continue to review full report at Codecov.
|
JafarAbdi
approved these changes
Nov 25, 2021
Member
JafarAbdi
left a comment
There was a problem hiding this comment.
Did you omit to reset total_compute_time_ on purpose or was it just missed? I would expect that the total compute time count restarts after a reset().
I missed it, thank you for the fix
JafarAbdi
pushed a commit
to JafarAbdi/moveit_task_constructor
that referenced
this pull request
Dec 21, 2021
JafarAbdi
pushed a commit
to JafarAbdi/moveit_task_constructor
that referenced
this pull request
Dec 21, 2021
JafarAbdi
pushed a commit
to JafarAbdi/moveit_task_constructor
that referenced
this pull request
Dec 21, 2021
JafarAbdi
pushed a commit
to JafarAbdi/moveit_task_constructor
that referenced
this pull request
Dec 22, 2021
mechwiz
pushed a commit
to mechwiz/moveit_task_constructor
that referenced
this pull request
May 4, 2022
mechwiz
pushed a commit
to mechwiz/moveit_task_constructor
that referenced
this pull request
May 19, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@JafarAbdi, I think you introduced
total_compute_time_. Did you omit to resettotal_compute_time_on purpose or was it just missed? I would expect that the total compute time count restarts after areset().